From 97127cf07a36bff2d53d05e6d88719b25f2a1706 Mon Sep 17 00:00:00 2001 From: smontlouis Date: Tue, 18 Aug 2026 14:11:15 +0200 Subject: [PATCH] fix(runtime): align roundness validation with studio --- packages/avatar-core/src/avatarDefinition.schema.json | 2 +- .../avatar/__tests__/avatar-definition-test.ts | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/packages/avatar-core/src/avatarDefinition.schema.json b/packages/avatar-core/src/avatarDefinition.schema.json index 018a161..b14d50b 100644 --- a/packages/avatar-core/src/avatarDefinition.schema.json +++ b/packages/avatar-core/src/avatarDefinition.schema.json @@ -59,7 +59,7 @@ "hexColor": { "type": "string", "pattern": "^#[0-9a-f]{6}$" }, "boundedNumber": { "type": "number", "minimum": -10000, "maximum": 10000 }, "dimension": { "type": "number", "minimum": 0.001, "maximum": 10000 }, - "roundness": { "type": "number", "minimum": 0, "maximum": 1 }, + "roundness": { "type": "number", "minimum": 0, "maximum": 2 }, "surface": { "type": "object", "additionalProperties": false, diff --git a/src/features/avatar/__tests__/avatar-definition-test.ts b/src/features/avatar/__tests__/avatar-definition-test.ts index e0ff488..4e17616 100644 --- a/src/features/avatar/__tests__/avatar-definition-test.ts +++ b/src/features/avatar/__tests__/avatar-definition-test.ts @@ -186,7 +186,7 @@ describe('avatar definition validation', () => { ], [ 'roundness maximum', - (value: AvatarDefinition) => (value.body.primary.roundness = 1.1), + (value: AvatarDefinition) => (value.body.primary.roundness = 2.1), 'maximum', ], [ @@ -285,7 +285,13 @@ describe('avatar definition validation', () => { definition.body.primary.width = 0.001 definition.body.primary.height = 10000 definition.body.primary.roundness = 0 - definition.body.primary.morphRoundness = 1 + definition.body.primary.morphRoundness = 2 + definition.body.primary.tipRoundness = 2 + definition.body.primary.baseRoundness = 2 + definition.body.nodes[0].surface.roundness = 2 + definition.body.nodes[0].surface.morphRoundness = 2 + definition.body.nodes[0].surface.tipRoundness = 2 + definition.body.nodes[0].surface.baseRoundness = 2 definition.body.nodes[0].position = [-10000, 0, 10000] definition.body.nodes[0].rotation = [-360, 0, 360] definition.expressions.neutral.head = { x: -10000, y: 0, z: 10000 }