mirror of
https://github.com/mattermost/mattermost-mobile.git
synced 2026-11-05 10:28:54 +00:00
f8a177ca48
* MM-70299 - display channel attributes in header, info and banner
* cover and expand channel attributes feature with UI and E2E tests
* Implement channel attributes lock and update related tests and API methods
* Enhance error logging and improve type definitions for channel attributes
* Handle error from setAccessControlGroupId in fetchAccessControlAttributeFields
* Refactor fetchAccessControlAttributeFields to include system ID handling and improve batch record persistence
* Address code review feedback: extract feature-flag constants, move DB-only helpers to query/local layers, refactor attribute chip styles, fix colour spelling, and add test coverage for value pruning and subtitle component
* Fix error handling in removeStoredFields function and delete obsolete end-to-end test file
* Add tests for removeStoredFields function and enhance property queries
* Fix removeStoredFields to recover group ID from classification anchor and clean all owned fields
* Fix batchRecords silently swallowing write errors in fetchAccessControlAttributeFields
* Remove unused visibility check for ChannelAttributeLabels in e2e tests
* Fix classification fetch cache and channel-attributes E2E lock contention
Do not stamp the classification banner cache when both access-control flags
are off, so turning a flag back on after a reload refetches fields.
Share the classification lock with the channel-attributes Detox suite and
stop unsetting ClassificationMarkings. Skip flag-on tests when the server
cannot enable ChannelAttributes.
* Scope access_control field prune to owned object types
handlePropertyFields(groupId) deletes every field in the group. The fetch
only returns system and channel fields, so same-group user/session rows
were removed on each refresh. Prune only system and channel fields, matching
removeStoredFields.
* fail channel attributes tests when feature enablement fails instead of silently reporting them as passed
* Compose all channel attribute values in banners with template resolution, mixed field support, and matching web colors
---------
(cherry picked from commit 54731fa6ac)
Co-authored-by: Pablo Vélez <pablovv2016@gmail.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: mattermost-code <matty-code@mattermost.com>
64 lines
2.7 KiB
TypeScript
64 lines
2.7 KiB
TypeScript
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
import {deriveClassificationBannerState} from './classification';
|
|
|
|
import type {PropertyFieldModel, PropertyValueModel} from '@database/models/server';
|
|
|
|
type ClassificationField = Pick<PropertyFieldModel, 'id' | 'name' | 'objectType' | 'attrs'>;
|
|
type ClassificationValue = Pick<PropertyValueModel, 'fieldId' | 'value'>;
|
|
|
|
const systemField: ClassificationField = {
|
|
id: 'sys-1',
|
|
name: 'classification',
|
|
objectType: 'system',
|
|
attrs: {
|
|
actions: ['display_banner_top'],
|
|
options: [
|
|
{id: 'opt-ts', name: 'TOP SECRET', color: '#FCE83A'},
|
|
{id: 'opt-s', name: 'SECRET', color: '#FF0000'},
|
|
],
|
|
},
|
|
};
|
|
|
|
const systemValue: ClassificationValue = {fieldId: 'sys-1', value: 'opt-ts'};
|
|
|
|
describe('deriveClassificationBannerState', () => {
|
|
it('should return hidden state when there are no fields', () => {
|
|
const result = deriveClassificationBannerState([], [systemValue]);
|
|
expect(result).toEqual({visible: false, levelName: '', color: ''});
|
|
});
|
|
|
|
it('should return hidden state when the system field is absent', () => {
|
|
const channelOnly: ClassificationField = {...systemField, name: 'classification', objectType: 'channel'};
|
|
const result = deriveClassificationBannerState([channelOnly], [systemValue]);
|
|
expect(result).toEqual({visible: false, levelName: '', color: ''});
|
|
});
|
|
|
|
it('should return hidden state when DISPLAY_BANNER_TOP action is missing', () => {
|
|
const noActionField: ClassificationField = {...systemField, attrs: {...systemField.attrs, actions: []}};
|
|
const result = deriveClassificationBannerState([noActionField], [systemValue]);
|
|
expect(result).toEqual({visible: false, levelName: '', color: ''});
|
|
});
|
|
|
|
it('should return hidden state when no system value is set', () => {
|
|
const result = deriveClassificationBannerState([systemField], []);
|
|
expect(result).toEqual({visible: false, levelName: '', color: ''});
|
|
});
|
|
|
|
it('should return visible state with correct level on happy path', () => {
|
|
const result = deriveClassificationBannerState([systemField], [systemValue]);
|
|
expect(result).toEqual({
|
|
visible: true,
|
|
levelName: 'TOP SECRET',
|
|
color: '#FCE83A',
|
|
});
|
|
});
|
|
|
|
it('should return hidden state when option id does not match any option', () => {
|
|
const badValue: ClassificationValue = {...systemValue, value: 'non-existent-opt'};
|
|
const result = deriveClassificationBannerState([systemField], [badValue]);
|
|
expect(result).toEqual({visible: false, levelName: '', color: ''});
|
|
});
|
|
});
|