mirror of
https://github.com/mattermost/mattermost-mobile.git
synced 2026-11-13 22:50:19 +00:00
These bent production behaviour to satisfy Detox rather than fixing a defect,
and none had evidence of being load-bearing:
- user_item: an opaque backgroundColor added purely so Detox visibility checks
pass on at-mention rows.
- recent_searches: removeClippedSubviews={false}, disabling a RN virtualisation
optimisation so Detox could see off-screen rows. Its unit test only asserted
removeClippedSubviews === false, so it goes with it.
- saved_messages route: unmounting the tab on blur to force withObservables to
resubscribe. The stated premise (a missed preference CREATE) does not hold —
WatermelonDB re-evaluates query membership on create/update/destroy, so both
saving and unsaving already emit. It cost a full remount per tab visit.
The genuine reactivity fix in this area is kept: observePostsById uses
observeWithColumns on the post body columns, because Query.observe() only emits
on set membership changes and an edit keeps the same id. That one is unit
tested (post.test.ts) and stays.
This commit is deliberately the risky one — if any of these were load-bearing,
CI will now say so instead of us guessing.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| index.ts | ||
| user_item.tsx | ||