mirror of
https://github.com/mattermost/mattermost-mobile.git
synced 2026-11-06 10:50:13 +00:00
127dfb535e
The maestro login subflow selected the username field by the exact string "Email, Username or AD/LDAP Username". That placeholder is assembled at runtime in app/screens/login/form.tsx from the server's auth config, so it only reads that way when email + username + LDAP sign-in are all enabled; a stock server renders "Email or Username" and Maestro's full-string regex misses. The CI template worked around it by enabling LDAP on the test server before every maestro job. That fixes the wrong layer: it leaves a permanently broken AD/LDAP option on a shared server's login screen, LdapSettings.Enable is a licensed field so the curl -f hard-fails an unlicensed server, and it is the same full-string-regex trap GUIDELINES.md warns about in this very PR. Match "Email.*Username" instead, which holds for both compositions, and drop the server patching. Also: - The config-baseline step is setup, not teardown, so it no longer runs under always(): after a failed or cancelled provision it would fire at a server that may not exist and mask the real seed failure with a curl error. The end-of-job AllowDownloadLogs restore keeps always(), which is what it is for. - Re-exclude MM-T5603 on iOS. It was un-excluded on three consecutive local greens, but it was quarantined as a ~50% intermittent with an unknown mechanism, and nothing about the flow changed - three greens against a coin flip is a 1-in-8 coincidence, not a fix. MM-T5611 stays enabled: it has a named root cause and two negative controls that failed as required. - Prune exclude_tags.json to the live exclusions and their reasons. The historical un-exclusion narratives are in git log; keeping them inline made the file grow without bound and re-serializing it escaped every non-ASCII character, so real edits arrived buried in whole-file diff noise. The QUIC transport finding was not about any exclusion and moves to README.md. |
||
|---|---|---|
| .. | ||
| actions | ||
| codeql | ||
| workflows | ||
| dependabot.yaml | ||
| ISSUE_TEMPLATE.md | ||
| PULL_REQUEST_TEMPLATE.md | ||