mirror of
https://github.com/mattermost/mattermost-mobile.git
synced 2026-11-06 02:40:15 +00:00
* MM-70299 - display channel attributes in header, info and banner * cover and expand channel attributes feature with UI and E2E tests * Implement channel attributes lock and update related tests and API methods * Enhance error logging and improve type definitions for channel attributes * Handle error from setAccessControlGroupId in fetchAccessControlAttributeFields * Refactor fetchAccessControlAttributeFields to include system ID handling and improve batch record persistence * Address code review feedback: extract feature-flag constants, move DB-only helpers to query/local layers, refactor attribute chip styles, fix colour spelling, and add test coverage for value pruning and subtitle component * Fix error handling in removeStoredFields function and delete obsolete end-to-end test file * Add tests for removeStoredFields function and enhance property queries * Fix removeStoredFields to recover group ID from classification anchor and clean all owned fields * Fix batchRecords silently swallowing write errors in fetchAccessControlAttributeFields * Remove unused visibility check for ChannelAttributeLabels in e2e tests * Fix classification fetch cache and channel-attributes E2E lock contention Do not stamp the classification banner cache when both access-control flags are off, so turning a flag back on after a reload refetches fields. Share the classification lock with the channel-attributes Detox suite and stop unsetting ClassificationMarkings. Skip flag-on tests when the server cannot enable ChannelAttributes. Co-authored-by: mattermost-code <matty-code@mattermost.com> * Scope access_control field prune to owned object types handlePropertyFields(groupId) deletes every field in the group. The fetch only returns system and channel fields, so same-group user/session rows were removed on each refresh. Prune only system and channel fields, matching removeStoredFields. Co-authored-by: mattermost-code <matty-code@mattermost.com> * fail channel attributes tests when feature enablement fails instead of silently reporting them as passed * Compose all channel attribute values in banners with template resolution, mixed field support, and matching web colors --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: mattermost-code <matty-code@mattermost.com> Co-authored-by: Mattermost Build <build@mattermost.com>
55 lines
2.7 KiB
TypeScript
55 lines
2.7 KiB
TypeScript
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
import {CLASSIFICATIONS_SYSTEM_OBJECT_TYPE} from '@constants/classification';
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Channel attributes
|
|
//
|
|
// A channel attribute is a PropertyField with object_type='channel', linked to
|
|
// a template field, holding one value per channel. Classification Markings is
|
|
// one instance of this shape rather than a separate system: it lives in the
|
|
// same `access_control` group and is selected by the same keys.
|
|
//
|
|
// Three layers, one direction of travel:
|
|
//
|
|
// template field - canonical name, type, options, colours, ranks
|
|
// channel field - ONE global field carrying per-channel settings in attrs
|
|
// channel value - one PropertyValue per channel, keyed on the channel field
|
|
//
|
|
// Everything rendered comes from joining the second to the third.
|
|
// ---------------------------------------------------------------------------
|
|
|
|
// The PSAv2 property group every channel attribute belongs to. Shared with
|
|
// Custom Profile Attributes and Classification Markings, which is why the
|
|
// group alone is not a narrow enough filter (see observeChannelAttributeFields).
|
|
export const ACCESS_CONTROL_GROUP_NAME = 'access_control';
|
|
|
|
export const CHANNEL_ATTRIBUTE_OBJECT_TYPE = 'channel';
|
|
|
|
// Values of a field's attrs.actions, deciding where its value displays. The
|
|
// server allow-lists exactly these four, so an unknown value here means the
|
|
// contract moved.
|
|
//
|
|
// display_banner_bottom is validated server-side but always renders at the top,
|
|
// so it is treated as top everywhere and never offered as a position.
|
|
export const DISPLAY_BANNER_TOP = 'display_banner_top';
|
|
export const DISPLAY_BANNER_BOTTOM = 'display_banner_bottom';
|
|
export const DISPLAY_LABEL_HEADER = 'display_label_header';
|
|
export const DISPLAY_LABEL_INFO = 'display_label_info';
|
|
|
|
// Feature flag config keys — stored as constants so callers don't spread bare
|
|
// strings and grep can find all references.
|
|
export const FEATURE_FLAG_CHANNEL_ATTRIBUTES = 'FeatureFlagChannelAttributes';
|
|
|
|
// Neutral chip colours for the dark channel header. Shared between AttributeChip
|
|
// and the +N overflow pill in ChannelAttributeLabels so both stay in sync.
|
|
export const NEUTRAL_CHIP_HEADER_BG = '#DADCE0';
|
|
export const NEUTRAL_CHIP_HEADER_TEXT = '#1D2433';
|
|
|
|
// The PropertyField object_types this feature owns inside the shared
|
|
// access_control group. Used to scope deletions and field-event fanout to only
|
|
// the rows that belong here — the group is shared with user/session fields that
|
|
// belong to other features.
|
|
export const OWNED_OBJECT_TYPES = new Set<PropertyFieldObjectType>([CLASSIFICATIONS_SYSTEM_OBJECT_TYPE, CHANNEL_ATTRIBUTE_OBJECT_TYPE]);
|