mattermost-mobile-upstream/app/client/rest/properties.ts
Pablo Vélez 4d842026f6
Some checks failed
ci / lint-typecheck (push) Has been cancelled
ci / detox-lint-typecheck (push) Has been cancelled
ci / test (push) Has been cancelled
CodeQL / Analyze (javascript) (push) Has been cancelled
Mm 70564 channel labels use in channel creation (#10146)
* MM-70516 - Add ability to edit channel attribute values from Channel Info

* Add API methods for patching property fields and setting channel attribute requirements

* Update channel attribute clearing behavior for required and non-required fields

* MM-70564 - use channel attributes on channel creation

* Fix undefined propertyValues and ternary formatting in channel attributes

* Fix spelling of "colour" to "color" in attribute chip tests and related comments

* Add visibility checks for channel attribute labels in tests

* Fix data-integrity, permission, and accessibility issues in channel attributes: scoped pruning, atomic writes, race serialization, required clear/stale-option guards

* Fix handling of null values in apiGetChannelAttributeValue and update test assertions for channel attributes

* Improve channel attribute editor sizing for long labels, keep Save visible, and prevent keyboard overlap on Android

* Address CodeRabbit feedback for nullable values, bottom-sheet state, async validation, and reliable E2E cleanup

* lock-safe field fetch, create-time gate recheck, scoped value pruning, and tappable header chips

* Address CodeRabbit feedback: drop queued attribute saves on channel switch and use page object selectors in E2E

* Respect the ChannelAttributesRequired flag on channel creation and enable it for channel attribute E2E

* Skip required channel attribute E2E tests and stop enabling ChannelAttributesRequired on the shared server until  they move to SITE_3

* Fix clearing channel attributes on iOS by sending an empty value instead of null, and stop E2E suites from turning  off the ChannelAttributes flag mid-run

* Refactor getEmptyPropertyValue to accept string type for fieldType parameter

* E2E: give channel attribute test fields a suite-unique suffix

Pool shards may only create optional property fields named <name>_<6 hex>; fixed names were blocked by the pool guard.

* E2E: restore channel attribute cleanup checks; name network error codes

Brings back the PR's afterEach/afterAll error handling that the main merge replaced, and makes a no-response error show its codes (an AggregateError has an empty message).

* E2E: run channel attribute creation and editing specs on server B

Their 11 required-attribute tests could not run on the shared servers. Both specs now run on the mutation server with ChannelAttributesRequired on for their run, and the tests are re-enabled. setChannelAttributesRequired moves to the shared helper.

* Check header chips instead of their wrapper and use toExist for the create screen in channel attribute E2E

---------

Co-authored-by: yasserfaraazkhan <attitude3cena.yf@gmail.com>
2026-10-30 15:03:55 +01:00

54 lines
3.4 KiB
TypeScript

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
import {safeArrayCast} from '@utils/helpers';
import type ClientBase from './base';
export interface ClientPropertiesMix {
getPropertyValues: <T>(groupName: string, objectType: string, targetId: string, groupLabel?: RequestGroupLabel) => Promise<Array<PropertyValue<T>>>;
getPropertyFields: (groupName: string, objectType: string, targetType: string, targetId?: string, groupLabel?: RequestGroupLabel) => Promise<PropertyField[]>;
searchPropertyFields: (groupName: string, options: PropertyFieldSearchOpts, groupLabel?: RequestGroupLabel) => Promise<PropertyField[]>;
getSystemPropertyValues: <T>(groupName: string, groupLabel?: RequestGroupLabel) => Promise<Array<PropertyValue<T>>>;
patchPropertyValues: <T>(groupName: string, objectType: string, targetId: string, items: Array<PropertyValuePatchItem<T>>, groupLabel?: RequestGroupLabel) => Promise<Array<PropertyValue<T | null>>>;
}
const ClientProperties = <TBase extends Constructor<ClientBase>>(superclass: TBase) => class extends superclass {
getPropertyValues = async <T>(groupName: string, objectType: string, targetId: string, groupLabel?: RequestGroupLabel) => {
const url = `${this.urlVersion}/properties/groups/${groupName}/${objectType}/values/${targetId}`;
return safeArrayCast<PropertyValue<T>>(await this.doFetch(url, {method: 'get', groupLabel}));
};
getPropertyFields = async (groupName: string, objectType: string, targetType: string, targetId?: string, groupLabel?: RequestGroupLabel) => {
let url = `${this.urlVersion}/properties/groups/${groupName}/${objectType}/fields?target_type=${targetType}`;
if (targetId !== undefined) {
url += `&target_id=${encodeURIComponent(targetId)}`;
}
return safeArrayCast<PropertyField>(await this.doFetch(url, {method: 'get', groupLabel}));
};
searchPropertyFields = async (groupName: string, options: PropertyFieldSearchOpts, groupLabel?: RequestGroupLabel) => {
const url = `${this.urlVersion}/properties/groups/${groupName}/fields/search`;
return safeArrayCast<PropertyField>(await this.doFetch(url, {method: 'post', body: options, groupLabel}));
};
getSystemPropertyValues = async <T>(groupName: string, groupLabel?: RequestGroupLabel) => {
const url = `${this.urlVersion}/properties/groups/${groupName}/system/values`;
return safeArrayCast<PropertyValue<T>>(await this.doFetch(url, {method: 'get', groupLabel}));
};
// The route takes a bare array, not an object, and upserts every item. A null
// value clears the field: the response carries a null-valued row rather than
// signalling a delete.
//
// The server caps the batch at MAX_PROPERTY_VALUE_PATCH_ITEMS and rejects a
// larger one outright rather than truncating, so a caller that ever batches
// has to chunk. Every caller today sends a single item.
patchPropertyValues = async <T>(groupName: string, objectType: string, targetId: string, items: Array<PropertyValuePatchItem<T>>, groupLabel?: RequestGroupLabel) => {
const url = `${this.urlVersion}/properties/groups/${groupName}/${objectType}/values/${targetId}`;
return safeArrayCast<PropertyValue<T | null>>(await this.doFetch(url, {method: 'patch', body: items, groupLabel}));
};
};
export default ClientProperties;