mirror of
https://github.com/mattermost/mattermost-mobile.git
synced 2026-11-08 12:10:13 +00:00
4d842026f6
* MM-70516 - Add ability to edit channel attribute values from Channel Info * Add API methods for patching property fields and setting channel attribute requirements * Update channel attribute clearing behavior for required and non-required fields * MM-70564 - use channel attributes on channel creation * Fix undefined propertyValues and ternary formatting in channel attributes * Fix spelling of "colour" to "color" in attribute chip tests and related comments * Add visibility checks for channel attribute labels in tests * Fix data-integrity, permission, and accessibility issues in channel attributes: scoped pruning, atomic writes, race serialization, required clear/stale-option guards * Fix handling of null values in apiGetChannelAttributeValue and update test assertions for channel attributes * Improve channel attribute editor sizing for long labels, keep Save visible, and prevent keyboard overlap on Android * Address CodeRabbit feedback for nullable values, bottom-sheet state, async validation, and reliable E2E cleanup * lock-safe field fetch, create-time gate recheck, scoped value pruning, and tappable header chips * Address CodeRabbit feedback: drop queued attribute saves on channel switch and use page object selectors in E2E * Respect the ChannelAttributesRequired flag on channel creation and enable it for channel attribute E2E * Skip required channel attribute E2E tests and stop enabling ChannelAttributesRequired on the shared server until they move to SITE_3 * Fix clearing channel attributes on iOS by sending an empty value instead of null, and stop E2E suites from turning off the ChannelAttributes flag mid-run * Refactor getEmptyPropertyValue to accept string type for fieldType parameter * E2E: give channel attribute test fields a suite-unique suffix Pool shards may only create optional property fields named <name>_<6 hex>; fixed names were blocked by the pool guard. * E2E: restore channel attribute cleanup checks; name network error codes Brings back the PR's afterEach/afterAll error handling that the main merge replaced, and makes a no-response error show its codes (an AggregateError has an empty message). * E2E: run channel attribute creation and editing specs on server B Their 11 required-attribute tests could not run on the shared servers. Both specs now run on the mutation server with ChannelAttributesRequired on for their run, and the tests are re-enabled. setChannelAttributesRequired moves to the shared helper. * Check header chips instead of their wrapper and use toExist for the create screen in channel attribute E2E --------- Co-authored-by: yasserfaraazkhan <attitude3cena.yf@gmail.com>
60 lines
3.0 KiB
TypeScript
60 lines
3.0 KiB
TypeScript
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Classification-markings constants
|
|
//
|
|
// The classification system uses two linked property-field "object types":
|
|
//
|
|
// 1. System field — drives the GLOBAL banner. Linked to the server-side
|
|
// template and inherits its options/colors.
|
|
// 2. Channel field — drives PER-CHANNEL banners. Also linked to the
|
|
// template and inherits its options/colors.
|
|
//
|
|
// Both fields share the same field name on the server and are distinguished
|
|
// only by their object_type ('system' vs 'channel'). They are also scoped
|
|
// server-side as system fields, so they share the same field-level target
|
|
// attributes (`target_type='system'`, `target_id=''`). Property *values* for
|
|
// the system field are stored on the dedicated system endpoint and use the
|
|
// sentinel target_id 'system'.
|
|
// ---------------------------------------------------------------------------
|
|
|
|
// Property-field group identifying all classification-markings entities.
|
|
// Classification is one tenant of the shared access_control group, so the name
|
|
// and the banner actions are defined once, alongside the generic channel
|
|
// attributes, and re-exported here for the existing classification callers.
|
|
export {
|
|
ACCESS_CONTROL_GROUP_NAME as CLASSIFICATIONS_GROUP_NAME,
|
|
DISPLAY_BANNER_TOP,
|
|
DISPLAY_BANNER_BOTTOM,
|
|
} from '@constants/channel_attributes';
|
|
|
|
// Field-level target attributes shared by system and channel fields.
|
|
// `target_type` is always 'system'; `target_id` is empty for system-scoped
|
|
// field definitions (the server canonicalizes both).
|
|
export const CLASSIFICATIONS_FIELD_TARGET_TYPE = 'system';
|
|
export const CLASSIFICATIONS_FIELD_TARGET_ID = '';
|
|
|
|
// Shared field name for both the system and channel classification fields.
|
|
export const CLASSIFICATIONS_FIELD_NAME = 'classification';
|
|
|
|
// System field — drives the global banner. Property *values* live on the
|
|
// dedicated system endpoint and use the sentinel target_id 'system'.
|
|
export const CLASSIFICATIONS_SYSTEM_OBJECT_TYPE = 'system';
|
|
export const CLASSIFICATIONS_SYSTEM_VALUE_TARGET_ID = 'system';
|
|
|
|
// Channel field — drives the per-channel banner.
|
|
export const CLASSIFICATIONS_CHANNEL_OBJECT_TYPE = 'channel';
|
|
|
|
// How long a successful classification-field fetch stays fresh in the in-memory
|
|
// cache before the global banner mount effect will request it again (1 hour).
|
|
export const CLASSIFICATION_BANNER_CACHE_TTL = 60 * 60 * 1000;
|
|
|
|
// How long a malformed-response failure suppresses non-forced re-fetches. Much
|
|
// shorter than the success TTL: this backs off a server sending a bad response
|
|
// on every request, not a value worth trusting for an hour.
|
|
export const CLASSIFICATION_BANNER_FAILURE_BACKOFF = 60 * 1000;
|
|
|
|
// Feature flag config key for the classification markings system.
|
|
export const FEATURE_FLAG_CLASSIFICATION_MARKINGS = 'FeatureFlagClassificationMarkings';
|