mirror of
https://github.com/mattermost/mattermost-mobile.git
synced 2026-11-04 18:08:54 +00:00
* MM-68219 - Add redacted files placeholder and related functionality * add feature flag control and e2e tests * adjust placeholder design, polish code, fix permalink preview issue * polish code and add missing test * use import path with right path * gate post refetch behind the feature flag, refetch the open thread and avoid observeCount * restore filesInfo for the permalink files prop added upstream * fix stale redaction on background servers, consume the flag on every fetch path and share the viewport emitter * replace the in-memory redaction flag with a persisted per-post epoch so ABAC file decisions survive restarts and stale posts stay hidden * raise the redaction epoch on every resync, capture the epoch counter, only invalidate channels on role changes, and store the newer epoch when a re-verified post is otherwise unchanged * store superseded responses unverified instead of dropping them, keep the since-fetch when re-verifying, verify permalink embeds against the linked channel, and capture the websocket epoch on arrival * nvalidate file decisions when a user attribute field changes or all its values are cleared * batch channel invalidations, close file viewers only when affected, reset the epoch on unstamped redaction changes, and only re-verify the newest page's attachment posts * re-check older channel posts a page at a time instead of one request per post * skip the unstamped epoch lookup for posts with no files, redacted count or permalink * keep the attribute-view retry after later invalidations, retry linked posts unless refused for the current epoch, and stop older payloads from rolling back edits via the redaction check * MM-70905 - disable and grey out the attachment button when an ABAC pe… (#10195) * MM-70905 - disable and grey out the attachment button when an ABAC permission policy denies uploads in the channel * only back off render permission fetches when the server request fails, and log other errors without retrying * remove the disableServer helper and have removeServer do both steps * split defaultAllowed into allowWhenUnenforced and allowWhenNotEvaluated, and treat render permissions as unenforced on servers without the decisions API * MM-69627: Add playbook task requirements support on mobile (#10035) * MM-69627: Add playbook task requirements support on mobile Allow filling required task fields when checking off checklist items during a run, gated by the same Playbooks beta setting used on web. Co-authored-by: Cursor <cursoragent@cursor.com> * MM-69627: Address PR review feedback for task requirements Propagate settings write failures, harden fill-requirements save/title handling, and add missing unit coverage. Co-authored-by: Cursor <cursoragent@cursor.com> * MM-69627: Fix TypeScript errors in new unit tests Co-authored-by: Cursor <cursoragent@cursor.com> * MM-69627: Use defineMessages for fill requirements titles Keep i18n extraction able to find the header titles after moving them to the route. Co-authored-by: Cursor <cursoragent@cursor.com> * MM-69627: Address review feedback for task requirements Update checklist items locally when saving requirement values instead of refetching the run, add missing query/navigation tests, and apply small callback/reduce cleanups from review. Co-authored-by: Cursor <cursoragent@cursor.com> * MM-69627: Fix task requirements review follow-ups Propagate local checklist write failures, clear a stale task-requirements flag when playbooks is unsupported, and cap fill values at the desktop/ server max length. Co-authored-by: Cursor <cursoragent@cursor.com> * MM-69627: Move requirement field into its own component Keep one component per file on the fill-requirements screen. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com> * MM-69122: Add file element support to interactive dialogs (#9898) * Implement Interactive Dialog - file upload * update demo plugin version for e2etests * fix and add e2etests * review fixes * Fix version bump checkout when a tag shares the branch name (#10229) * Fix Android crashes caused by animated custom emoji (#10030) * Route GIF decoding through Glide - Keep APNG4Android for APNG, animated WebP, and animated AVIF support. - Prepend Glide's GIF decoders to avoid APNG4Android's native GIF overflow. * Clear Expo image resources with Glide targets - Detach drawables when Glide clears their custom target. - Prevent recycled GIF frame resources from remaining attached to Expo image views. * Preserve foreground image during GIF target recycling --------- Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> Co-authored-by: Nuno Simões <nuno.simoes@mattermost.com> Co-authored-by: MangelSpec <74370284+MangelSpec@users.noreply.github.com> * detox - fix clobbering of feature flags that cause failures in other suites. Also small fix of a incorrectly set test-id --------- Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Scott Bishel <scott.bishel@mattermost.com> Co-authored-by: Nuno Simões <nuno.simoes@mattermost.com> Co-authored-by: MangelSpec <74370284+MangelSpec@users.noreply.github.com> Co-authored-by: Nate Schlossberg <nate.schlossberg@mattermost.com>
133 lines
6.2 KiB
TypeScript
133 lines
6.2 KiB
TypeScript
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
import {advanceTimers} from '@test/timer_helpers';
|
|
|
|
import type {RenderPermissionsEntry} from './render_permissions_store';
|
|
|
|
const serverUrl = 'https://server.test';
|
|
const otherServerUrl = 'https://other.test';
|
|
const channelId = 'channel-id';
|
|
|
|
const entry: RenderPermissionsEntry = {
|
|
epoch: 3,
|
|
decisions: {upload_file_attachment: {allowed: false, evaluated: true}},
|
|
};
|
|
|
|
describe('RenderPermissionsStore', () => {
|
|
let RenderPermissionsStore: typeof import('./render_permissions_store').default;
|
|
let TTL: number;
|
|
let RETRY: number;
|
|
|
|
beforeEach(() => {
|
|
jest.useFakeTimers({doNotFake: ['nextTick']});
|
|
jest.resetModules();
|
|
const module = require('./render_permissions_store');
|
|
RenderPermissionsStore = module.default;
|
|
TTL = module.RENDER_PERMISSIONS_TTL_MS;
|
|
RETRY = module.RENDER_PERMISSIONS_RETRY_MS;
|
|
});
|
|
|
|
afterEach(() => {
|
|
jest.useRealTimers();
|
|
});
|
|
|
|
it('should mark an entry expired once its time to live has passed, keeping its decisions', async () => {
|
|
RenderPermissionsStore.setEntry(serverUrl, channelId, entry, TTL);
|
|
await advanceTimers(TTL);
|
|
|
|
expect(RenderPermissionsStore.getEntry(serverUrl, channelId)).toEqual({...entry, expired: true});
|
|
});
|
|
|
|
it('should restart the time to live when an entry is replaced', async () => {
|
|
RenderPermissionsStore.setEntry(serverUrl, channelId, entry, TTL);
|
|
await advanceTimers(TTL - 1);
|
|
|
|
const next = {...entry, epoch: 4};
|
|
RenderPermissionsStore.setEntry(serverUrl, channelId, next, TTL);
|
|
await advanceTimers(TTL - 1);
|
|
|
|
expect(RenderPermissionsStore.getEntry(serverUrl, channelId)).toBe(next);
|
|
});
|
|
|
|
it('should emit to a channel observer only when that channel changes', () => {
|
|
const emitted: Array<RenderPermissionsEntry | undefined> = [];
|
|
const subscription = RenderPermissionsStore.observeEntry(serverUrl, channelId).subscribe((e) => emitted.push(e));
|
|
|
|
RenderPermissionsStore.setEntry(serverUrl, 'another-channel', entry, TTL);
|
|
RenderPermissionsStore.setEntry(serverUrl, channelId, entry, TTL);
|
|
|
|
expect(emitted).toEqual([undefined, entry]);
|
|
subscription.unsubscribe();
|
|
});
|
|
|
|
it('should share one in-flight slot per channel', () => {
|
|
const claim = RenderPermissionsStore.startFetch(serverUrl, channelId);
|
|
expect(claim).toBeDefined();
|
|
expect(RenderPermissionsStore.startFetch(serverUrl, channelId)).toBeUndefined();
|
|
expect(RenderPermissionsStore.startFetch(serverUrl, 'another-channel')).toBeDefined();
|
|
|
|
RenderPermissionsStore.finishFetch(serverUrl, channelId, claim as object, entry);
|
|
|
|
expect(RenderPermissionsStore.getEntry(serverUrl, channelId)).toBe(entry);
|
|
expect(RenderPermissionsStore.startFetch(serverUrl, channelId)).toBeDefined();
|
|
});
|
|
|
|
it('should discard an answer whose server was removed, even after the user logged straight back in', () => {
|
|
const oldSession = RenderPermissionsStore.startFetch(serverUrl, channelId);
|
|
RenderPermissionsStore.removeServer(serverUrl);
|
|
const newSession = RenderPermissionsStore.startFetch(serverUrl, channelId);
|
|
|
|
RenderPermissionsStore.finishFetch(serverUrl, channelId, oldSession as object, entry);
|
|
expect(RenderPermissionsStore.getEntry(serverUrl, channelId)).toBeUndefined();
|
|
|
|
RenderPermissionsStore.finishFetch(serverUrl, channelId, newSession as object, entry);
|
|
expect(RenderPermissionsStore.getEntry(serverUrl, channelId)).toBe(entry);
|
|
});
|
|
|
|
it('should expire only the given server in a single emission and revoke its requests in flight on a network change', () => {
|
|
RenderPermissionsStore.setEntry(serverUrl, channelId, entry, TTL);
|
|
RenderPermissionsStore.setEntry(serverUrl, 'second-channel', entry, TTL);
|
|
RenderPermissionsStore.setEntry(otherServerUrl, channelId, entry, TTL);
|
|
const inFlight = RenderPermissionsStore.startFetch(serverUrl, 'another-channel');
|
|
const listener = jest.fn();
|
|
const subscription = RenderPermissionsStore.observeEntry(serverUrl, 'second-channel').subscribe(listener);
|
|
listener.mockClear();
|
|
|
|
RenderPermissionsStore.expireServer(serverUrl);
|
|
|
|
expect(RenderPermissionsStore.getEntry(serverUrl, channelId)?.expired).toBe(true);
|
|
expect(RenderPermissionsStore.getEntry(serverUrl, 'second-channel')?.expired).toBe(true);
|
|
expect(listener).toHaveBeenCalledTimes(1);
|
|
expect(RenderPermissionsStore.getEntry(otherServerUrl, channelId)?.expired).toBeUndefined();
|
|
|
|
// Evaluated for the network the device left, so it is not stored and does not block a new request.
|
|
RenderPermissionsStore.finishFetch(serverUrl, 'another-channel', inFlight as object, entry);
|
|
expect(RenderPermissionsStore.getEntry(serverUrl, 'another-channel')).toBeUndefined();
|
|
expect(RenderPermissionsStore.startFetch(serverUrl, 'another-channel')).toBeDefined();
|
|
subscription.unsubscribe();
|
|
});
|
|
|
|
it('should back off exponentially on consecutive transient outcomes, up to the time to live', () => {
|
|
expect(RenderPermissionsStore.nextRetryDelay(serverUrl, channelId)).toBe(RETRY);
|
|
expect(RenderPermissionsStore.nextRetryDelay(serverUrl, channelId)).toBe(RETRY * 2);
|
|
for (let i = 0; i < 10; i++) {
|
|
RenderPermissionsStore.nextRetryDelay(serverUrl, channelId);
|
|
}
|
|
expect(RenderPermissionsStore.nextRetryDelay(serverUrl, channelId)).toBe(TTL);
|
|
|
|
RenderPermissionsStore.resetRetryDelay(serverUrl, channelId);
|
|
expect(RenderPermissionsStore.nextRetryDelay(serverUrl, channelId)).toBe(RETRY);
|
|
});
|
|
|
|
it('should forget only the given server on removeServer', () => {
|
|
RenderPermissionsStore.setEntry(serverUrl, channelId, entry, TTL);
|
|
RenderPermissionsStore.setEntry(otherServerUrl, channelId, entry, TTL);
|
|
|
|
RenderPermissionsStore.removeServer(serverUrl);
|
|
|
|
expect(RenderPermissionsStore.getEntry(serverUrl, channelId)).toBeUndefined();
|
|
expect(RenderPermissionsStore.getEntry(otherServerUrl, channelId)).toBe(entry);
|
|
});
|
|
});
|