mattermost-mobile-upstream/app/utils/classification.test.ts
Andre Vasconcelos e18fc6921e
MM-68208 Implementing global and channel-level banners on mobile (#9752)
* Expo-Router partial migration

* Full migration to ExpoRouter

* i18n

* add tests

* library hardware-keyboard android new arch support fix

* library rnshare android new arch support fix

* library rnutils android new arch support fix

* library secure-pdf-viewer add new arch support

* Enable new arch on iOS and Android

* update emm and network client with new-arch

* update intune to use new-arch

* performance improvements

* fix tests

* fixes post input on new-arch

* Merge branch 'main' into expo-router

* fix android emoji picker

* align package-lock.json

* i18n

* feedback review

* feedback review

* android 16kb patch

* Refactored emoji picker keyboard using a state machine

* set android launch_screen in drawables instead of layout

* no conditional hooks

* remove duplicate call in test

* address feedback

* fix tests and address more feedback

* small corrections

* small corrections

* small corrections

* fix draft test

* fix draft test 2

* remove navigateToScreen in draff test

* fix nit in draft test

* remove doc file

* remove doc

* run tests in parallel

* Feedback review

* fix snapshots

* improve test coverage

* fix i18n

* upgrade to React Native 0.83.9, Expo 55, React 19, and New Architecture

Bumps core dependencies to their latest versions:
- React Native 0.77.3 → 0.83.9 (New Architecture enabled)
- React 18.3.1 → 19.2.5
- Expo SDK 52 → 55
- TypeScript 5.8.3 → 6.0.3
- Node.js 22.16.0 → 24.15.0
- react-native-reanimated 3.17.3 → 4.3.0
- Various other dependency upgrades

Migrates iOS AppDelegate from Objective-C to Swift, updates Android
build tooling and Gradle wrapper, refreshes all patches and font
assets, and adapts app code, tests, and CI workflows throughout for
API changes introduced by these upgrades.

* remove unecessary dismissKeyboard in notifications

* feedback review

* update intune to use new-arch

* update @mattermost deps

* missing i18n string

* additional fixes

* update fastlane

* Re-implementing global classification banners on top of rn83

* Refactoring to de-couple the classification banner from the layout

* Implementing per-channel banners on mobile

* Removing custom header in favor of common component

* Making fixes for coderabbit

* Improving padding calculation

* Converting global classification banner to use portals

* Removing dead code, adding deletion check

* Addressing dryrun securit concerns

* Removing call for template field, improving consistency

* MM-68208 Storing system property values in WatermelonDB (#9781)

* Added persistence layer to system properties

* Making debounce behavior more consistent

* Cleaning up debounce logic from store persistence

* Addressing PR feedback

* Removing ephemeral store usage and employing observables

- Changing name of group to access_control

* Updating unit tests

* Refactoring to improve code consistency

- Removing any patterns introduced that weren't already established in the repo
- Removing hooks with database reads in favor of withObservables and withDatabase pattern
- Simplifying _layout.tsx by removing inset modification, now handled in the Container HoC component
- Moved some repeated hook logic into its own utils file

* Refactoring to use propertyfield and propertyvalue tables instead of system

- Simplified remote actions to purely perform API call, and call a local action to sync values
- Using local action layer to perform syncing and removal operations of property fields and values
- Observables now pre-filter for active fields / values via querying for delete_at=0

* Improving consistency of local actions

- Added unit tests for syncPropertyFieldsByGroupId, syncPropertyValuesByTargetId, clearClassificationData

* Replacing local actions with operator handlers

* Removing needless mocks from unit tests

* Consolidating operator handlers

- Leaving 1 handler for fields and 1 for values, each of them evaluating whether to delete or upsert values received in the function call

* MM-68208 Making changes based on feedback

- Removing !visible guard in global classification container
- Increasing clarity of comment for clearing of stale fields
- Updating log messages to be more clear

* Batching database operations together for fields and values

* Consolidating API call for fetching classification data

- Preparation for caching mechanism

* Updating field names to the unified classification

* Updating E2E test values to match current field names

---------

Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
2026-07-08 12:47:01 +03:00

117 lines
4.8 KiB
TypeScript

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
import {
deriveChannelClassificationBanner,
deriveClassificationBannerState,
} from './classification';
import type {PropertyFieldModel, PropertyValueModel} from '@database/models/server';
type ClassificationField = Pick<PropertyFieldModel, 'id' | 'name' | 'objectType' | 'attrs'>;
type ClassificationValue = Pick<PropertyValueModel, 'fieldId' | 'value'>;
const systemField: ClassificationField = {
id: 'sys-1',
name: 'classification',
objectType: 'system',
attrs: {
actions: ['display_banner_top'],
options: [
{id: 'opt-ts', name: 'TOP SECRET', color: '#FCE83A'},
{id: 'opt-s', name: 'SECRET', color: '#FF0000'},
],
},
};
const systemValue: ClassificationValue = {fieldId: 'sys-1', value: 'opt-ts'};
describe('deriveClassificationBannerState', () => {
it('should return hidden state when there are no fields', () => {
const result = deriveClassificationBannerState([], [systemValue]);
expect(result).toEqual({visible: false, levelName: '', color: ''});
});
it('should return hidden state when the system field is absent', () => {
const channelOnly: ClassificationField = {...systemField, name: 'classification', objectType: 'channel'};
const result = deriveClassificationBannerState([channelOnly], [systemValue]);
expect(result).toEqual({visible: false, levelName: '', color: ''});
});
it('should return hidden state when DISPLAY_BANNER_TOP action is missing', () => {
const noActionField: ClassificationField = {...systemField, attrs: {...systemField.attrs, actions: []}};
const result = deriveClassificationBannerState([noActionField], [systemValue]);
expect(result).toEqual({visible: false, levelName: '', color: ''});
});
it('should return hidden state when no system value is set', () => {
const result = deriveClassificationBannerState([systemField], []);
expect(result).toEqual({visible: false, levelName: '', color: ''});
});
it('should return visible state with correct level on happy path', () => {
const result = deriveClassificationBannerState([systemField], [systemValue]);
expect(result).toEqual({
visible: true,
levelName: 'TOP SECRET',
color: '#FCE83A',
});
});
it('should return hidden state when option id does not match any option', () => {
const badValue: ClassificationValue = {...systemValue, value: 'non-existent-opt'};
const result = deriveClassificationBannerState([systemField], [badValue]);
expect(result).toEqual({visible: false, levelName: '', color: ''});
});
});
const channelField: ClassificationField = {
id: 'cf-1',
name: 'classification',
objectType: 'channel',
attrs: {
options: [
{id: 'level-secret', name: 'Secret', color: '#FF0000'},
{id: 'level-public', name: 'Public', color: '#00FF00'},
],
},
};
const channelValue: ClassificationValue = {fieldId: 'cf-1', value: 'level-secret'};
describe('deriveChannelClassificationBanner', () => {
it('should return no classification when there are no fields', () => {
const result = deriveChannelClassificationBanner([], []);
expect(result.hasClassification).toBe(false);
expect(result.classificationBanner).toBeUndefined();
});
it('should return no classification when there is no channel value', () => {
const result = deriveChannelClassificationBanner([channelField], []);
expect(result.hasClassification).toBe(false);
});
it('should resolve classification banner from channel value and field options', () => {
const result = deriveChannelClassificationBanner([channelField], [channelValue]);
expect(result.hasClassification).toBe(true);
expect(result.classificationBanner).toEqual({
enabled: true,
text: '**Secret**',
background_color: '#FF0000',
});
});
it('should use native banner text when provided', () => {
const result = deriveChannelClassificationBanner([channelField], [channelValue], 'Custom banner text');
expect(result.hasClassification).toBe(true);
expect(result.classificationBanner?.text).toBe('Custom banner text');
expect(result.classificationBanner?.background_color).toBe('#FF0000');
});
it('should return no classification when level id does not match any option', () => {
const unknownValue: ClassificationValue = {...channelValue, value: 'nonexistent-level'};
const result = deriveChannelClassificationBanner([channelField], [unknownValue]);
expect(result.hasClassification).toBe(false);
});
});