mirror of
https://github.com/mattermost/mattermost-mobile.git
synced 2026-11-06 10:50:13 +00:00
4a74a5be75
* [MM-70605][MM-70607] Scope pre-auth secret storage per server
The pre-auth secret was written with react-native-keychain's generic-password
API using the `server` option, which those calls do not read. Every server
therefore resolved to one shared entry, and a falsy secret argument deleted it,
so ordinary operations such as building a client, refreshing the token header or
removing another server discarded the stored value.
Key the entry per server instead. On Android the alias namespace is shared with
internet credentials, so the service is prefixed to keep it away from the
session token; iOS uses the bare server URL, which is what the native reader in
Gekidou already queries. The account value is renamed to `preauth_secret` on
both sides. Writing the token no longer touches the secret: removal is explicit,
via removePreauthSecret.
A one-time migration adopts the previously shared entry when a single server
makes ownership unambiguous, and discards it otherwise. It only deletes the old
entry once the new one is confirmed stored, and defers when no server is active.
Also forward the secret through the login screen to SSO, and fix loginOptions to
count only enabled providers so the single-provider redirect works. Relands the
`.enabled` filter from #9585 by @pltnm239.
Edit Server now updates the live client's headers rather than invalidating the
session, and validates with the candidate secret so a value the server rejects
cannot be saved.
* [MM-70605] Harden preauth secret flows and fix Edit Server Detox on iOS
Address review feedback around migration markers, credential errors, and
keeping re-login secrets out of nav params. Focus the empty Authentication
secret field via Display Name return so iOS Detox can type into it.
* [MM-70605] Fix lines-around-comment in Edit Server Detox helper
* [MM-70605] Roll back preauth keychain when Edit Server client sync fails
After the secret is stored, header apply or createClient failures left the
new value in secure storage while UI state still held the old baseline.
Restore the previous secret (and live header) before surfacing the error.
* [MM-70605] Preserve exact preauth secret on Edit Server rollback
Avoid trimming during keychain restore so boundary whitespace from the
previously stored value is not altered.
* [MM-70605] Harden preauth migration ownership and secret handoff
Adopt the legacy secret only when a single server exists in the app DB,
keep add-server candidates in EphemeralStore instead of nav params, and
resync the live client to stored credentials when keychain rollback fails.
* [MM-70605] Discard the legacy preauth secret when no server can own it
* [MM-70605] Shorten the preauth migration docblock
* [MM-70605] Skip the Authorization header when there is no bearer token
* [MM-70605] Surface preauth secret rejections with a specific error message
* [MM-70605] Mock clearPendingPreauthSecret in session action tests
* [MM-70605] Remove the unreachable catch from restorePreviousPreauthSecret
setPreauthSecret and removePreauthSecret never reject, and the returned promise was not awaited, so the catch could not run.
* [MM-70605] Use network-client fix for the iOS addHeaders crash
Temporary pin to mattermost/react-native-network-client#175 to check CI. Replace with the released version before merge.
* [MM-70605] Bump react-native-network-client to 1.11.5
1.11.5 gives each recreated iOS session its own delegate in addHeaders, which fixes the SIGTRAP on pre-auth secret changes.
---------
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| entry | ||
| apps.test.ts | ||
| apps.ts | ||
| category.test.ts | ||
| category.ts | ||
| channel_access_control_attributes.ts | ||
| channel_bookmark.test.ts | ||
| channel_bookmark.ts | ||
| channel.test.ts | ||
| channel.ts | ||
| classification.test.ts | ||
| classification.ts | ||
| command.test.ts | ||
| command.ts | ||
| custom_emoji.test.ts | ||
| custom_emoji.ts | ||
| custom_profile.test.ts | ||
| custom_profile.ts | ||
| ephemeral_mode.test.ts | ||
| ephemeral_mode.ts | ||
| file.test.ts | ||
| file.ts | ||
| general.test.ts | ||
| general.ts | ||
| groups.test.ts | ||
| groups.ts | ||
| integrations.test.ts | ||
| integrations.ts | ||
| license.test.ts | ||
| license.ts | ||
| notifications.test.ts | ||
| notifications.ts | ||
| performance.test.ts | ||
| performance.ts | ||
| permalink.ts | ||
| post.auxiliary.test.ts | ||
| post.auxiliary.ts | ||
| post.test.ts | ||
| post.ts | ||
| preference.test.ts | ||
| preference.ts | ||
| reactions.test.ts | ||
| reactions.ts | ||
| refresh.test.ts | ||
| refresh.ts | ||
| render_permissions.test.ts | ||
| render_permissions.ts | ||
| restore_server.test.ts | ||
| restore_server.ts | ||
| retry.test.ts | ||
| retry.ts | ||
| role.ts | ||
| scheduled_post.test.ts | ||
| scheduled_post.ts | ||
| search.test.ts | ||
| search.ts | ||
| session_attributes.test.ts | ||
| session_attributes.ts | ||
| session.test.ts | ||
| session.ts | ||
| systems.test.ts | ||
| systems.ts | ||
| team.test.ts | ||
| team.ts | ||
| terms_of_service.test.ts | ||
| terms_of_service.ts | ||
| thread.test.ts | ||
| thread.ts | ||
| user.test.ts | ||
| user.ts | ||