mattermost-mobile-upstream/app/actions/websocket/system.test.ts
Pablo Vélez 7df4a0ab97
Some checks are pending
ci / lint-typecheck (push) Waiting to run
ci / detox-lint-typecheck (push) Waiting to run
ci / test (push) Waiting to run
Mm 68219 show placeholder for redacted files (#9719)
* MM-68219 - Add redacted files placeholder and related functionality

* add feature flag control and e2e tests

* adjust placeholder design, polish code, fix permalink preview issue

* polish code and add missing test

* use import path with right path

* gate post refetch behind the feature flag, refetch the open thread and avoid observeCount

* restore filesInfo for the permalink files prop added upstream

* fix stale redaction on background servers, consume the flag on every fetch path and share the viewport emitter

* replace the in-memory redaction flag with a persisted per-post epoch so ABAC file decisions survive restarts and stale posts stay hidden

* raise the redaction epoch on every resync, capture the epoch counter, only invalidate channels on role changes, and store the newer epoch when a re-verified post is otherwise unchanged

* store superseded responses unverified instead of dropping them, keep the since-fetch when re-verifying, verify permalink embeds against the linked channel, and capture the websocket epoch on arrival

* nvalidate file decisions when a user attribute field changes or all its values are cleared

* batch channel invalidations, close file viewers only when affected, reset the epoch on unstamped redaction changes, and only  re-verify the newest page's attachment posts

* re-check older channel posts a page at a time instead of one request per post

* skip the unstamped epoch lookup for posts with no files, redacted count or permalink

* keep the attribute-view retry after later invalidations, retry linked posts unless refused for the current epoch, and stop older payloads from rolling back edits via the redaction check

* MM-70905 - disable and grey out the attachment button when an ABAC pe… (#10195)

* MM-70905 - disable and grey out the attachment button when an ABAC permission policy denies uploads in the channel

* only back off render permission fetches when the server request fails, and log other errors without retrying

* remove the disableServer helper and have removeServer do both steps

* split defaultAllowed into allowWhenUnenforced and allowWhenNotEvaluated, and treat render permissions as unenforced  on servers without the decisions API

* MM-69627: Add playbook task requirements support on mobile (#10035)

* MM-69627: Add playbook task requirements support on mobile

Allow filling required task fields when checking off checklist items during
a run, gated by the same Playbooks beta setting used on web.

Co-authored-by: Cursor <cursoragent@cursor.com>

* MM-69627: Address PR review feedback for task requirements

Propagate settings write failures, harden fill-requirements save/title handling, and add missing unit coverage.

Co-authored-by: Cursor <cursoragent@cursor.com>

* MM-69627: Fix TypeScript errors in new unit tests

Co-authored-by: Cursor <cursoragent@cursor.com>

* MM-69627: Use defineMessages for fill requirements titles

Keep i18n extraction able to find the header titles after moving them to the route.

Co-authored-by: Cursor <cursoragent@cursor.com>

* MM-69627: Address review feedback for task requirements

Update checklist items locally when saving requirement values instead of
refetching the run, add missing query/navigation tests, and apply small
callback/reduce cleanups from review.

Co-authored-by: Cursor <cursoragent@cursor.com>

* MM-69627: Fix task requirements review follow-ups

Propagate local checklist write failures, clear a stale task-requirements
flag when playbooks is unsupported, and cap fill values at the desktop/
server max length.

Co-authored-by: Cursor <cursoragent@cursor.com>

* MM-69627: Move requirement field into its own component

Keep one component per file on the fill-requirements screen.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Cursor <cursoragent@cursor.com>

* MM-69122: Add file element support to interactive dialogs (#9898)

* Implement Interactive Dialog - file upload

* update demo plugin version for e2etests

* fix and add e2etests

* review fixes

* Fix version bump checkout when a tag shares the branch name (#10229)

* Fix Android crashes caused by animated custom emoji (#10030)

* Route GIF decoding through Glide

- Keep APNG4Android for APNG, animated WebP, and animated AVIF support.
- Prepend Glide's GIF decoders to avoid APNG4Android's native GIF overflow.

* Clear Expo image resources with Glide targets

- Detach drawables when Glide clears their custom target.
- Prevent recycled GIF frame resources from remaining attached to Expo image views.

* Preserve foreground image during GIF target recycling

---------

Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
Co-authored-by: Nuno Simões <nuno.simoes@mattermost.com>
Co-authored-by: MangelSpec <74370284+MangelSpec@users.noreply.github.com>

* detox - fix clobbering of feature flags that cause failures in other suites.  Also small fix of a incorrectly set test-id

---------

Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Scott Bishel <scott.bishel@mattermost.com>
Co-authored-by: Nuno Simões <nuno.simoes@mattermost.com>
Co-authored-by: MangelSpec <74370284+MangelSpec@users.noreply.github.com>
Co-authored-by: Nate Schlossberg <nate.schlossberg@mattermost.com>
2026-10-15 15:59:13 -07:00

261 lines
10 KiB
TypeScript

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
import {updateDmGmDisplayName} from '@actions/local/channel';
import {reconcilePersistenceFlag} from '@actions/local/ephemeral_mode/wipe';
import {invalidateRedactionGlobally, RedactionInvalidationReason} from '@actions/local/redaction';
import {storeConfig} from '@actions/local/systems';
import {invalidateRedactionForCurrentUser} from '@actions/websocket/access_control';
import {SYSTEM_IDENTIFIERS} from '@constants/database';
import DatabaseManager from '@database/manager';
import SessionAttributesManager from '@managers/session_attributes_manager';
import {getConfig, getLicense} from '@queries/servers/system';
import {handleLicenseChangedEvent, handleConfigChangedEvent} from './system';
import type ServerDataOperator from '@database/operator/server_data_operator';
jest.mock('@actions/local/channel');
jest.mock('@actions/local/ephemeral_mode/wipe');
jest.mock('@actions/local/systems');
jest.mock('@actions/local/redaction', () => ({
...jest.requireActual('@actions/local/redaction'),
invalidateRedactionGlobally: jest.fn(),
}));
jest.mock('@actions/websocket/access_control');
jest.mock('@database/manager');
jest.mock('@managers/session_attributes_manager', () => ({
__esModule: true,
default: {
refreshManifest: jest.fn().mockResolvedValue(undefined),
removeServer: jest.fn(),
},
}));
jest.mock('@queries/servers/system');
describe('WebSocket System Actions', () => {
const serverUrl = 'baseHandler.test.com';
let operator: ServerDataOperator;
let handleSystem: jest.SpyInstance;
beforeEach(async () => {
jest.clearAllMocks();
await DatabaseManager.init([serverUrl]);
operator = DatabaseManager.serverDatabases[serverUrl]!.operator;
handleSystem = jest.spyOn(operator, 'handleSystem');
});
afterEach(async () => {
await DatabaseManager.destroyServerDatabase(serverUrl);
jest.restoreAllMocks();
});
describe('handleLicenseChangedEvent', () => {
it('should handle missing operator', async () => {
DatabaseManager.serverDatabases = {};
const msg = {
data: {
license: {
LockTeammateNameDisplay: true,
},
},
} as WebSocketMessage;
await handleLicenseChangedEvent(serverUrl, msg);
expect(handleSystem).not.toHaveBeenCalled();
});
it('should handle license update with no display name change', async () => {
const mockLicense = {
LockTeammateNameDisplay: false,
};
jest.mocked(getLicense).mockResolvedValue({
LockTeammateNameDisplay: 'false',
} as ClientLicense);
const msg = {
data: {
license: mockLicense,
},
} as WebSocketMessage;
await handleLicenseChangedEvent(serverUrl, msg);
expect(handleSystem).toHaveBeenCalledWith({
systems: [{
id: SYSTEM_IDENTIFIERS.LICENSE,
value: JSON.stringify(mockLicense),
}],
prepareRecordsOnly: false,
});
expect(updateDmGmDisplayName).not.toHaveBeenCalled();
});
it('should handle license update with display name change', async () => {
const mockLicense = {
LockTeammateNameDisplay: true,
};
jest.mocked(getLicense).mockResolvedValue({
LockTeammateNameDisplay: 'false',
} as ClientLicense);
const msg = {
data: {
license: mockLicense,
},
} as WebSocketMessage;
await handleLicenseChangedEvent(serverUrl, msg);
expect(handleSystem).toHaveBeenCalled();
expect(updateDmGmDisplayName).toHaveBeenCalledWith(serverUrl);
});
it('should invalidate file decisions only when the license crosses the ABAC tier', async () => {
// Below Enterprise Advanced the ABAC engine refuses to evaluate and every decision denies.
const advanced = {IsLicensed: 'true', SkuShortName: 'advanced'} as ClientLicense;
const professional = {IsLicensed: 'true', SkuShortName: 'professional'} as ClientLicense;
jest.mocked(getLicense).mockResolvedValue(advanced);
await handleLicenseChangedEvent(serverUrl, {data: {license: {...advanced, Users: '100'}}} as WebSocketMessage);
expect(invalidateRedactionForCurrentUser).not.toHaveBeenCalled();
await handleLicenseChangedEvent(serverUrl, {data: {license: professional}} as WebSocketMessage);
expect(invalidateRedactionForCurrentUser).toHaveBeenCalledTimes(1);
expect(invalidateRedactionForCurrentUser).toHaveBeenCalledWith(serverUrl, RedactionInvalidationReason.LicenseChanged);
});
});
describe('handleConfigChangedEvent', () => {
it('should handle missing operator', async () => {
DatabaseManager.serverDatabases = {};
const msg = {
data: {
config: {
LockTeammateNameDisplay: true,
},
},
} as WebSocketMessage;
await handleConfigChangedEvent(serverUrl, msg);
expect(storeConfig).not.toHaveBeenCalled();
});
it('should invalidate file decisions in both directions of an ABAC enforcement change', async () => {
// On: nothing cached before enforcement may be trusted. Off: cached denials must be re-checked.
const enforced = {FeatureFlagPermissionPolicies: 'true', EnableAttributeBasedAccessControl: 'true'} as ClientConfig;
const notEnforced = {FeatureFlagPermissionPolicies: 'true', EnableAttributeBasedAccessControl: 'false'} as ClientConfig;
jest.mocked(getConfig).mockResolvedValue(notEnforced);
await handleConfigChangedEvent(serverUrl, {data: {config: enforced}} as WebSocketMessage);
expect(invalidateRedactionForCurrentUser).toHaveBeenCalledWith(serverUrl, RedactionInvalidationReason.ConfigChanged);
expect(invalidateRedactionGlobally).not.toHaveBeenCalled();
jest.mocked(getConfig).mockResolvedValue(enforced);
await handleConfigChangedEvent(serverUrl, {data: {config: notEnforced}} as WebSocketMessage);
expect(invalidateRedactionGlobally).toHaveBeenCalledWith(serverUrl, RedactionInvalidationReason.ConfigChanged);
});
it('should handle config update with no display name change', async () => {
const mockConfig = {
LockTeammateNameDisplay: false,
};
jest.mocked(getConfig).mockResolvedValue({
LockTeammateNameDisplay: 'false',
} as ClientConfig);
const msg = {
data: {
config: mockConfig,
},
} as WebSocketMessage;
await handleConfigChangedEvent(serverUrl, msg);
expect(storeConfig).toHaveBeenCalledWith(serverUrl, mockConfig);
expect(updateDmGmDisplayName).not.toHaveBeenCalled();
});
it('should handle config update with display name change', async () => {
const mockConfig = {
LockTeammateNameDisplay: true,
};
jest.mocked(getConfig).mockResolvedValue({
LockTeammateNameDisplay: 'false',
} as ClientConfig);
const msg = {
data: {
config: mockConfig,
},
} as WebSocketMessage;
await handleConfigChangedEvent(serverUrl, msg);
expect(storeConfig).toHaveBeenCalledWith(serverUrl, mockConfig);
expect(updateDmGmDisplayName).toHaveBeenCalledWith(serverUrl);
});
it('should re-init session attributes when feature flag is enabled', async () => {
jest.mocked(getConfig).mockResolvedValue({
FeatureFlagSessionAttributes: 'false',
} as ClientConfig);
const msg = {
data: {
config: {
FeatureFlagSessionAttributes: 'true',
},
},
} as WebSocketMessage;
await handleConfigChangedEvent(serverUrl, msg);
expect(SessionAttributesManager.refreshManifest).toHaveBeenCalledWith(serverUrl);
// The session attributes sent with each request are part of the ABAC subject.
expect(invalidateRedactionForCurrentUser).toHaveBeenCalledWith(serverUrl, RedactionInvalidationReason.SessionAttributes);
});
it('should stop sending session attributes when feature flag is disabled', async () => {
jest.mocked(getConfig).mockResolvedValue({
FeatureFlagSessionAttributes: 'true',
} as ClientConfig);
const msg = {
data: {
config: {
FeatureFlagSessionAttributes: 'false',
},
},
} as WebSocketMessage;
await handleConfigChangedEvent(serverUrl, msg);
expect(SessionAttributesManager.removeServer).toHaveBeenCalledWith(serverUrl);
});
it('should reconcile the persistence flag against the new config so a live MEM-cleanup change clears zero-persistence', async () => {
const mockConfig = {
MobileEphemeralModeEnabled: 'true',
MobileEphemeralModeAutoCacheCleanupDays: '5',
};
jest.mocked(getConfig).mockResolvedValue({
MobileEphemeralModeEnabled: 'true',
MobileEphemeralModeAutoCacheCleanupDays: '0',
} as ClientConfig);
const msg = {data: {config: mockConfig}} as WebSocketMessage;
await handleConfigChangedEvent(serverUrl, msg);
expect(reconcilePersistenceFlag).toHaveBeenCalledWith(serverUrl, mockConfig);
});
});
});