mattermost-mobile-upstream/app/screens/edit_post/edit_post.test.tsx
Elias Nahum b6fc85385e
Migrate from RNN to Expo router (#9402)
* Expo-Router partial migration

* Full migration to ExpoRouter

* i18n

* add tests

* Merge branch 'main' into expo-router

* align package-lock.json

* i18n

* feedback review

* feedback review

* android 16kb patch

* Refactored emoji picker keyboard using a state machine

* set android launch_screen in drawables instead of layout

* no conditional hooks

* remove duplicate call in test

* address feedback

* fix tests and address more feedback

* small corrections

* small corrections

* small corrections

* fix draft test

* fix draft test 2

* remove navigateToScreen in draff test

* fix nit in draft test

* remove doc file

* Feedback review

* fix snapshots

* improve test coverage

* fix i18n

* Upgrade t o RN 0.83, other dependencies and new architecture (#9737)

* library hardware-keyboard android new arch support fix

* library rnshare android new arch support fix

* library rnutils android new arch support fix

* library secure-pdf-viewer add new arch support

* Enable new arch on iOS and Android

* update emm and network client with new-arch

* update intune to use new-arch

* performance improvements

* fix tests

* fixes post input on new-arch

* fix android emoji picker

* remove doc

* run tests in parallel

* upgrade to React Native 0.83.9, Expo 55, React 19, and New Architecture

Bumps core dependencies to their latest versions:
- React Native 0.77.3 → 0.83.9 (New Architecture enabled)
- React 18.3.1 → 19.2.5
- Expo SDK 52 → 55
- TypeScript 5.8.3 → 6.0.3
- Node.js 22.16.0 → 24.15.0
- react-native-reanimated 3.17.3 → 4.3.0
- Various other dependency upgrades

Migrates iOS AppDelegate from Objective-C to Swift, updates Android
build tooling and Gradle wrapper, refreshes all patches and font
assets, and adapts app code, tests, and CI workflows throughout for
API changes introduced by these upgrades.

* remove unecessary dismissKeyboard in notifications

* feedback review

* update intune to use new-arch

* update @mattermost deps

* missing i18n string

* additional fixes

* update fastlane
2026-05-13 17:44:55 +08:00

328 lines
11 KiB
TypeScript

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
import {act, waitFor} from '@testing-library/react-native';
import React from 'react';
import {Alert} from 'react-native';
import DraftEditPostUploadManager from '@managers/draft_upload_manager';
import {fireEvent, renderWithEverything} from '@test/intl-test-helper';
import TestHelper from '@test/test_helper';
import PickerUtil from '@utils/file/file_picker';
import {openAttachmentOptions} from '@utils/navigation';
import EditPost from './edit_post';
import type {Database} from '@nozbe/watermelondb';
import type PostModel from '@typings/database/models/servers/post';
import type {IntlShape} from 'react-intl';
jest.mock('@utils/file/file_picker');
jest.mock('@managers/draft_upload_manager', () => ({
prepareUpload: jest.fn(),
isUploading: jest.fn(() => false),
registerProgressHandler: jest.fn(() => jest.fn()),
registerErrorHandler: jest.fn(() => jest.fn()),
cancel: jest.fn(),
}));
jest.mock('@screens/navigation', () => ({
buildNavigationButton: jest.fn((id: string, testID: string) => ({id, testID})),
dismissBottomSheet: jest.fn(() => Promise.resolve()),
dismissModal: jest.fn(),
setButtons: jest.fn(),
}));
jest.mock('@utils/navigation', () => ({
openAttachmentOptions: jest.fn(),
}));
const TEST_CONFIG = {
serverUrl: 'baseHandler.test.com',
maxPostSize: 1000,
maxFileCount: 10,
maxFileSize: 1000,
} as const;
const TEST_FILES = {
existingFile1: {
id: 'file-1',
name: 'test-1',
extension: 'png',
has_preview_image: true,
height: 100,
mime_type: 'test',
size: 100,
user_id: '1',
width: 100,
},
existingFile2: {
id: 'file-2',
name: 'test-2',
extension: 'pdf',
has_preview_image: false,
height: 100,
mime_type: 'test',
size: 100,
user_id: '1',
width: 100,
},
newFile: {
clientId: 'file-3',
id: 'file-3',
name: 'test-3',
extension: 'txt',
mime_type: 'text/plain',
size: 999,
},
smallFile: {
name: 'test.txt',
mime_type: 'text/plain',
},
largeFile: {
name: 'test.txt',
mime_type: 'text/plain',
size: 1001,
},
} as const satisfies Record<string, Partial<ExtractedFileInfo>>;
const ERROR_MESSAGES = {
uploadsDisabled: 'File uploads from mobile are disabled.',
maxFilesReached: 'Uploads limited to 1 files maximum.',
fileTooLarge: 'Files must be less than 1000 B',
confirmDelete: 'Delete attachment',
confirmDeleteMessage: 'Are you sure you want to remove test-3?',
} as const;
describe('Edit Post', () => {
let database: Database;
const baseProps: Parameters<typeof EditPost>[0] = {
post: {
id: '1',
channelId: '1',
message: 'test',
messageSource: 'test',
userId: '1',
rootId: '1',
metadata: {},
} as PostModel,
maxPostSize: TEST_CONFIG.maxPostSize,
canDelete: true,
files: [TEST_FILES.existingFile1, TEST_FILES.existingFile2],
maxFileCount: TEST_CONFIG.maxFileCount,
maxFileSize: TEST_CONFIG.maxFileSize,
canUploadFiles: true,
};
const setupPickerMock = (file: Partial<ExtractedFileInfo>) => {
jest.mocked(PickerUtil).mockImplementation((intl, onUploadFiles) => ({
attachFileFromFiles: jest.fn(() => {
onUploadFiles?.([file as ExtractedFileInfo]);
return Promise.resolve({error: undefined});
}),
attachFileFromPhotoGallery: jest.fn(() => {
onUploadFiles?.([file as ExtractedFileInfo]);
return Promise.resolve({error: undefined});
}),
attachFileFromCamera: jest.fn(() => {
onUploadFiles?.([file as ExtractedFileInfo]);
return Promise.resolve({error: undefined});
}),
}) as unknown as PickerUtil);
};
const renderEditPost = (props = baseProps) => {
return renderWithEverything(<EditPost {...props}/>, {
database,
serverUrl: TEST_CONFIG.serverUrl,
});
};
const triggerFileUpload = async (screen: ReturnType<typeof renderEditPost>) => {
let onUploadFilesCallback: ((files: ExtractedFileInfo[]) => void) | undefined;
jest.mocked(openAttachmentOptions).mockImplementation((props) => {
onUploadFilesCallback = props?.onUploadFiles;
return undefined;
});
await act(async () => {
fireEvent.press(screen.getByTestId('edit_post.quick_actions.attachment_action'));
});
if (onUploadFilesCallback) {
await act(async () => {
const mockIntl = {formatMessage: jest.fn()} as unknown as IntlShape;
const mockPicker = new PickerUtil(mockIntl, onUploadFilesCallback as (files: ExtractedFileInfo[]) => void);
await mockPicker.attachFileFromFiles(undefined, true);
});
}
};
const triggerFileRemoval = async (screen: ReturnType<typeof renderEditPost>, fileId: string) => {
await act(async () => {
fireEvent.press(screen.getByTestId(`remove-button-${fileId}`));
});
};
beforeAll(async () => {
const server = await TestHelper.setupServerDatabase(TEST_CONFIG.serverUrl);
database = server.database;
const operator = server.operator;
operator.handleConfigs({
configs: [
{id: 'Version', value: '10.5.0'},
{id: 'EnableFileAttachments', value: 'true'},
{id: 'EnableMobileFileUpload', value: 'true'},
],
configsToDelete: [],
prepareRecordsOnly: false,
});
});
beforeEach(() => {
jest.clearAllMocks();
});
describe('Rendering', () => {
it('should render existing attachments in edit mode', () => {
const screen = renderEditPost();
expect(screen.getByTestId('uploads')).toBeVisible();
expect(screen.getByTestId('file-1')).toBeVisible();
expect(screen.getByTestId('file-2')).toBeVisible();
});
});
describe('File Upload Validation', () => {
it('should show error when file uploads are disabled', async () => {
setupPickerMock(TEST_FILES.smallFile);
const props = {...baseProps, canUploadFiles: false};
const screen = renderEditPost(props);
await triggerFileUpload(screen);
await waitFor(() => {
expect(screen.getByText(ERROR_MESSAGES.uploadsDisabled)).toBeVisible();
});
});
it('should show error when maximum file count is reached', async () => {
setupPickerMock(TEST_FILES.smallFile);
const props = {...baseProps, maxFileCount: 1};
const screen = renderEditPost(props);
await triggerFileUpload(screen);
await waitFor(() => {
expect(screen.getByText(ERROR_MESSAGES.maxFilesReached)).toBeVisible();
});
});
it('should show error when file size exceeds limit', async () => {
setupPickerMock(TEST_FILES.largeFile);
const props = {...baseProps, maxFileSize: 1000};
const screen = renderEditPost(props);
await triggerFileUpload(screen);
await waitFor(() => {
expect(screen.getByText(ERROR_MESSAGES.fileTooLarge)).toBeVisible();
});
});
});
describe('File Upload Integration', () => {
it('should integrate with DraftEditPostUploadManager for successful uploads', async () => {
setupPickerMock(TEST_FILES.newFile);
const screen = renderEditPost();
await triggerFileUpload(screen);
await waitFor(() => {
expect(DraftEditPostUploadManager.prepareUpload).toHaveBeenCalledWith(
TEST_CONFIG.serverUrl,
TEST_FILES.newFile,
baseProps.post.channelId,
baseProps.post.rootId,
0,
true,
expect.any(Function),
);
expect(DraftEditPostUploadManager.registerErrorHandler).toHaveBeenCalledWith(
TEST_FILES.newFile.clientId,
expect.any(Function),
);
});
});
});
describe('File Removal', () => {
beforeEach(() => {
jest.mocked(DraftEditPostUploadManager.isUploading).mockReturnValue(true);
setupPickerMock(TEST_FILES.newFile);
});
it('should remove newly uploaded files without confirmation', async () => {
const screen = renderEditPost();
await triggerFileUpload(screen);
await triggerFileRemoval(screen, TEST_FILES.newFile.id);
expect(Alert.alert).not.toHaveBeenCalled();
await waitFor(() => {
expect(DraftEditPostUploadManager.cancel).toHaveBeenCalledWith(TEST_FILES.newFile.clientId);
});
});
it('should show confirmation dialog for existing files', async () => {
const screen = renderEditPost();
await triggerFileRemoval(screen, TEST_FILES.existingFile1.id);
await waitFor(() => {
expect(Alert.alert).toHaveBeenCalledWith(
ERROR_MESSAGES.confirmDelete,
'Are you sure you want to remove test-1?',
expect.any(Array),
);
});
});
});
describe('Error Display', () => {
it('should display upload error in PostError component when file upload fails', async () => {
setupPickerMock(TEST_FILES.largeFile);
const props = {...baseProps, maxFileSize: 1000};
const screen = renderEditPost(props);
// Trigger file upload that will cause size error
await triggerFileUpload(screen);
// Verify that the PostError component is displayed with the error
await waitFor(() => {
expect(screen.getByTestId('edit_post.message.input.error')).toBeVisible();
expect(screen.getByText(ERROR_MESSAGES.fileTooLarge)).toBeVisible();
});
});
it('should display upload error with divider when error is present', async () => {
setupPickerMock(TEST_FILES.smallFile);
const props = {...baseProps, canUploadFiles: false};
const screen = renderEditPost(props);
// Trigger file upload that will cause upload disabled error
await triggerFileUpload(screen);
// Verify that the error is displayed
await waitFor(() => {
expect(screen.getByText(ERROR_MESSAGES.uploadsDisabled)).toBeVisible();
});
// Verify that the PostError component has the hasError styling applied
const editPostInput = screen.getByTestId('edit_post.message.input');
expect(editPostInput).toBeVisible();
});
it('should not display PostError component when no upload error exists', () => {
const screen = renderEditPost();
// Verify that no error message is displayed
expect(screen.queryByTestId('edit_post.message.input.error')).toBeNull();
});
});
});