mattermost-mobile-upstream/app/actions/remote
Guillermo Vayá 73488f0b4b fix(drafts): close 3 residual gaps in Phase-4 review fixes (#1, #2, #6)
Re-verification of the 11 Phase-4 review fixes surfaced 3 that were only
partially closed:

#2 (busy loop): drainOutbox skipped a mis-scoped teamId='' row with a bare
`continue`, leaving it Pending-and-due. scheduleWork kept counting it as due
work and re-armed a zero-delay drain that skipped it again — a CPU spin. Now
the skip backs off next_attempt_at (via computeNextAttemptAt), so the row
leaves the due set until its channel/membership may hydrate; a valid drain
resets the count.

#1 (torn-down DB write): the GET/reconcile path wrote the snapshot after the
HTTP await with no post-HTTP guard — only the POST/DELETE workers had one.
reconcileTeamDrafts now takes ReconcileOpts.shouldAbort and re-checks
shouldAbortPostHttpWrite before every per-draft write, failing closed if the
server was torn down mid-GET.

#6 (observation fence too late): the in-flight observation ordinal was bumped
only after reconcileTeamDrafts fully returned (after the whole apply loop),
leaving a window where a concurrent POST ack cleared the outbox first. The
bump now runs synchronously via ReconcileOpts.onSnapshot the moment the GET
resolves, before any apply-loop await.

Adds regression tests for each; all affected suites green (tsc + eslint clean).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-08-07 12:34:56 +02:00
..
entry fix(drafts): wake the coordinator on local mutations + init on DB-recreation paths (#7, #11) 2026-08-05 12:19:51 +02:00
apps.test.ts
apps.ts
category.test.ts [MM-68255] Enable mobile support for Managed Categories (#9683) 2026-04-16 10:01:51 -04:00
category.ts fix: app bugs surfaced by Detox RF migration (#9789) 2026-06-09 13:25:42 +05:30
channel_access_control_attributes.ts
channel_bookmark.test.ts
channel_bookmark.ts
channel.test.ts Migrate from RNN to Expo router (#9402) 2026-05-13 17:44:55 +08:00
channel.ts [MM-69457] Stop logging PII in exportable app logs (#9884) 2026-07-02 12:19:04 +02:00
classification.test.ts MM-68208 Implementing global and channel-level banners on mobile (#9752) 2026-07-08 12:47:01 +03:00
classification.ts MM-68208 Implementing global and channel-level banners on mobile (#9752) 2026-07-08 12:47:01 +03:00
command.test.ts Migrate from RNN to Expo router (#9402) 2026-05-13 17:44:55 +08:00
command.ts Migrate from RNN to Expo router (#9402) 2026-05-13 17:44:55 +08:00
custom_emoji.test.ts
custom_emoji.ts
custom_profile.test.ts
custom_profile.ts
draft.test.ts fix(drafts): close 3 residual gaps in Phase-4 review fixes (#1, #2, #6) 2026-08-07 12:34:56 +02:00
draft.ts fix(drafts): close 3 residual gaps in Phase-4 review fixes (#1, #2, #6) 2026-08-07 12:34:56 +02:00
file.test.ts
file.ts
general.test.ts Migrate from RNN to Expo router (#9402) 2026-05-13 17:44:55 +08:00
general.ts Fix case-insensitive pre-auth header check in doPing (#9577) 2026-03-17 12:07:07 +01:00
groups.test.ts
groups.ts
integrations.test.ts Mattermost Blocks (#9764) 2026-06-29 18:42:16 +02:00
integrations.ts Mattermost Blocks (#9764) 2026-06-29 18:42:16 +02:00
license.test.ts
license.ts
notifications.test.ts Migrate from RNN to Expo router (#9402) 2026-05-13 17:44:55 +08:00
notifications.ts Migrate from RNN to Expo router (#9402) 2026-05-13 17:44:55 +08:00
performance.test.ts
performance.ts
permalink.ts Migrate from RNN to Expo router (#9402) 2026-05-13 17:44:55 +08:00
post.auxiliary.test.ts [MM-66467] Missing messages (#9827) 2026-06-15 11:20:58 +02:00
post.auxiliary.ts fix critical crashes on Android (#9871) 2026-06-23 02:40:21 +08:00
post.test.ts [MM-67889] Fix permalinks to unjoined channels (#9624) 2026-04-06 00:08:53 -07:00
post.ts [MM-67889] Fix permalinks to unjoined channels (#9624) 2026-04-06 00:08:53 -07:00
preference.test.ts Revert "e2e(detox): Rainforest to Detox migration (#9790)" (#9834) 2026-06-15 17:57:01 +02:00
preference.ts fix: app bugs surfaced by Detox RF migration (#9789) 2026-06-09 13:25:42 +05:30
reactions.test.ts
reactions.ts
refresh.test.ts fix(drafts): wake the coordinator on local mutations + init on DB-recreation paths (#7, #11) 2026-08-05 12:19:51 +02:00
refresh.ts fix(drafts): wake the coordinator on local mutations + init on DB-recreation paths (#7, #11) 2026-08-05 12:19:51 +02:00
restore_server.test.ts Mm 68767 zero persistence (#9803) 2026-07-16 13:55:45 +02:00
restore_server.ts Mm 68767 zero persistence (#9803) 2026-07-16 13:55:45 +02:00
retry.test.ts
retry.ts
role.ts Migrate from RNN to Expo router (#9402) 2026-05-13 17:44:55 +08:00
scheduled_post.test.ts
scheduled_post.ts
search.test.ts
search.ts Keep users in archived channels when server omits ExperimentalViewArchivedChannels (MM-65820) (#9815) 2026-06-09 19:47:37 +00:00
session.test.ts Receive Mattermost Calls through iOS native incoming-call UI (#9780) 2026-06-16 12:08:14 -03:00
session.ts Receive Mattermost Calls through iOS native incoming-call UI (#9780) 2026-06-16 12:08:14 -03:00
systems.test.ts Mm 68767 zero persistence (#9803) 2026-07-16 13:55:45 +02:00
systems.ts Mm 68767 zero persistence (#9803) 2026-07-16 13:55:45 +02:00
team.test.ts MM-68575: Use server getMyTeams for canJoinOtherTeams check (#9736) 2026-05-13 10:23:21 -07:00
team.ts MM-68575: Use server getMyTeams for canJoinOtherTeams check (#9736) 2026-05-13 10:23:21 -07:00
terms_of_service.test.ts
terms_of_service.ts fix critical crashes on Android (#9871) 2026-06-23 02:40:21 +08:00
thread.test.ts Revert "e2e(detox): Rainforest to Detox migration (#9790)" (#9834) 2026-06-15 17:57:01 +02:00
thread.ts fix: app bugs surfaced by Detox RF migration (#9789) 2026-06-09 13:25:42 +05:30
user.test.ts Mm 68767 zero persistence (#9803) 2026-07-16 13:55:45 +02:00
user.ts Mm 68767 zero persistence (#9803) 2026-07-16 13:55:45 +02:00