mattermost-mobile-upstream/app/actions/remote/refresh.ts
Guillermo Vayá d7b455fec8 fix(drafts): wake the coordinator on local mutations + init on DB-recreation paths (#7, #11)
- #7 wake: every committed portable Draft mutation (updateDraftMessage,
  updateDraftFile, removeDraftFile, addFilesToDraft, updateDraftPriority,
  updateDraftBoRConfig, removeDraft) now calls DraftSyncManager.wake(serverUrl) on
  its success path so newly-enqueued outbox work drains promptly instead of
  waiting for a timer. Device-local markdown-metadata and error/no-op paths do
  not wake.
- #11 lifecycle: login.ts initializes DraftSyncManager for a freshly added server
  (after EphemeralModeManager.addServer, before WebSocket startup). refresh.ts
  applyPersistenceModeChange invalidates before the persistence-mode DB wipe and
  re-initializes after the database is recreated (before WebSocket startup), so a
  late HTTP completion can never touch a destroyed/recreated database.

Checks: npm run tsc clean; eslint --quiet clean; local-draft + refresh suites pass
(incl. an invalidate<wipe<initialize<createClient ordering assertion).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-08-05 12:19:51 +02:00

99 lines
4.5 KiB
TypeScript

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
import {wipeServerDatabaseWithRetry, wipeServerFiles} from '@actions/local/ephemeral_mode/wipe';
import {cancelSessionNotification, terminateSession} from '@actions/local/session';
import DatabaseManager from '@database/manager';
import {getServerCredentials} from '@init/credentials';
import DraftSyncManager from '@managers/draft_sync_manager';
import EphemeralModeManager from '@managers/ephemeral_mode_manager';
import WebsocketManager from '@managers/websocket_manager';
import {getCurrentChannelId, getCurrentTeamId, getPushVerificationStatus, prepareCommonSystemValues} from '@queries/servers/system';
import {getFullErrorMessage} from '@utils/errors';
import {logError, logWarning} from '@utils/log';
import {refetchCurrentUser} from './user';
export const applyPersistenceModeChange = async (serverUrl: string): Promise<{error?: unknown}> => {
let resumeServerTracking = true;
try {
// untrack server during the transition
EphemeralModeManager.removeServer(serverUrl);
const credentials = await getServerCredentials(serverUrl);
const {database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
// Snapshot SYSTEM values that the WS reconnect won't restore on its own so the post-wipe
// UI doesn't show a regressed state (push-proxy red alert, team-select screen flash, etc).
const previousPushVerificationStatus = await getPushVerificationStatus(database);
const previousCurrentTeamId = await getCurrentTeamId(database);
const previousCurrentChannelId = await getCurrentChannelId(database);
try {
await cancelSessionNotification(serverUrl);
} catch {
logWarning('applyPersistenceModeChange: cancelSessionNotification failed (non-critical)');
}
await WebsocketManager.invalidateClient(serverUrl);
// Stop draft sync before the DB is destroyed so late HTTP callbacks can't touch it.
DraftSyncManager.invalidate(serverUrl);
const {success} = await wipeServerDatabaseWithRetry(serverUrl);
if (!success) {
throw new Error('Failed to wipe server database after changing persistence mode');
}
wipeServerFiles(serverUrl);
const {error: refetchError} = await refetchCurrentUser(serverUrl, undefined);
if (refetchError) {
throw new Error(`applyPersistenceModeChange: failed to seed current user: ${getFullErrorMessage(refetchError)}`);
}
const {operator} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
const systemModels = await prepareCommonSystemValues(operator, {
currentPushVerificationStatus: previousPushVerificationStatus,
currentTeamId: previousCurrentTeamId,
currentChannelId: previousCurrentChannelId,
});
if (systemModels?.length) {
await operator.batchRecords(systemModels, 'applyPersistenceModeChange');
}
// The DB has been recreated and re-seeded; re-initialize draft sync before WebSocket startup.
await DraftSyncManager.initialize(serverUrl);
if (credentials?.token) {
await WebsocketManager.createClient(serverUrl, credentials.token, credentials.preauthSecret);
await WebsocketManager.initializeClient(serverUrl);
}
// Touch lastActiveAt so withServerDatabase re-reads the newly-created database instance.
// Only needed (and safe) for the active server
const activeServerUrl = await DatabaseManager.getActiveServerUrl();
if (activeServerUrl === serverUrl) {
await DatabaseManager.setActiveServerDatabase(serverUrl);
}
return {};
} catch (error) {
logError('applyPersistenceModeChange', serverUrl, getFullErrorMessage(error));
const {error: logoutError} = await terminateSession(serverUrl, false);
if (logoutError) {
logError('applyPersistenceModeChange: terminateSession failed', serverUrl, getFullErrorMessage(logoutError));
} else {
// do not resume server tracking in case of session termination
resumeServerTracking = false;
}
return {error};
} finally {
if (resumeServerTracking) {
// restart tracking; file cache was already wiped during the transition
await EphemeralModeManager.addServer(serverUrl, {cleanFileCache: false});
}
}
};