mattermost-mobile-upstream/app/actions/websocket/preferences.test.ts
Guillermo Vayá 62c694adeb feat(drafts): Phase 5 — WebSocket + lifecycle triggers make sync live
Wires the DraftSyncManager's reconcile/WS entry points (previously defined
but never called in production) into the app's WebSocket and lifecycle flow.
Design choice: WS draft events are treated as CHANGE SIGNALS that trigger an
authoritative GET reconcile of the current team, not applied directly — this
reuses Phase 4's matrix/scope/absence/observation-fence, and the server's
silent empty-upsert delete (no event) forces GET-reconciliation regardless.
The current-team GET also returns the user's DM/GM drafts, so it converges
them too; other teams' channel drafts converge on team switch.

Triggers:
- draft_created / draft_deleted WS events -> enqueue -> reconcile current team
  (constants + app/actions/websocket/draft.ts handler + event dispatch cases).
- Reconnect/first-connect: requestReconcile in doReconnect after entry batches.
- Team switch: requestReconcile in handleTeamChange (before the tablet early
  return, so both paths fire).
- Foreground: WebsocketManager forwards app-active to DraftSyncManager.onForeground
  (covers a socket that stayed open, so no reconnect fired). No second AppState
  listener is added.
- Capability change: handleCapabilityChange after config (AllowSyncedDrafts) and
  after sync_drafts preference create/update/delete batches.

Also adds a central empty-team guard in requestReconcile (the GET is per-team).

Deferred (noted for a follow-up): Global Drafts stale-on-open reconcile (touches
a screen, needs on-device verification); direct-apply of buffered WS events (the
buffer is retained, reserved for that future optimization).

tsc + eslint clean; new/updated unit tests across manager, ws handler, event
dispatch, reconnect, team switch, config/preference capability. All affected
suites green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-08-15 16:50:19 +02:00

304 lines
11 KiB
TypeScript

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
import {updateDmGmDisplayName} from '@actions/local/channel';
import {fetchPostById} from '@actions/remote/post';
import {handleCRTToggled} from '@actions/remote/preference';
import {Preferences} from '@constants';
import DatabaseManager from '@database/manager';
import DraftSyncManager from '@managers/draft_sync_manager';
import {getPostById} from '@queries/servers/post';
import {deletePreferences, differsFromLocalNameFormat, getHasCRTChanged} from '@queries/servers/preference';
import EphemeralStore from '@store/ephemeral_store';
import {handlePreferenceChangedEvent, handlePreferencesChangedEvent, handlePreferencesDeletedEvent} from './preferences';
import type ServerDataOperator from '@database/operator/server_data_operator';
jest.mock('@actions/local/channel');
jest.mock('@actions/remote/post');
jest.mock('@actions/remote/preference');
jest.mock('@database/manager');
jest.mock('@queries/servers/post');
jest.mock('@queries/servers/preference');
jest.mock('@store/ephemeral_store');
jest.mock('@managers/draft_sync_manager', () => ({
__esModule: true,
default: {handleCapabilityChange: jest.fn()},
}));
const syncDraftsPreference = {
category: Preferences.CATEGORIES.ADVANCED_SETTINGS,
name: Preferences.ADVANCED_SYNC_DRAFTS,
user_id: 'user1',
value: 'false',
};
describe('WebSocket Preferences Actions', () => {
const serverUrl = 'baseHandler.test.com';
let operator: ServerDataOperator;
beforeEach(async () => {
jest.clearAllMocks();
await DatabaseManager.init([serverUrl]);
operator = DatabaseManager.serverDatabases[serverUrl]!.operator;
jest.spyOn(operator, 'handlePreferences').mockResolvedValue([]);
jest.mocked(EphemeralStore.isEnablingCRT).mockReturnValue(false);
jest.mocked(EphemeralStore.isRecentlyUnsavedSavedPost).mockReturnValue(false);
});
afterEach(async () => {
await DatabaseManager.destroyServerDatabase(serverUrl);
});
describe('handlePreferenceChangedEvent', () => {
const mockPreference = {
category: Preferences.CATEGORIES.SAVED_POST,
name: 'post1',
user_id: 'user1',
value: 'true',
};
it('should handle enabling CRT', async () => {
jest.mocked(EphemeralStore.isEnablingCRT).mockReturnValue(true);
const msg = {
data: {
preference: JSON.stringify(mockPreference),
},
} as WebSocketMessage;
await handlePreferenceChangedEvent(serverUrl, msg);
expect(operator.handlePreferences).not.toHaveBeenCalled();
});
it('should handle preference change with saved post', async () => {
const msg = {
data: {
preference: JSON.stringify(mockPreference),
},
} as WebSocketMessage;
jest.mocked(differsFromLocalNameFormat).mockResolvedValue(false);
jest.mocked(getHasCRTChanged).mockResolvedValue(false);
jest.mocked(getPostById).mockResolvedValue(undefined);
await handlePreferenceChangedEvent(serverUrl, msg);
expect(operator.handlePreferences).toHaveBeenCalledWith({
prepareRecordsOnly: false,
preferences: [mockPreference],
});
expect(fetchPostById).toHaveBeenCalledWith(serverUrl, 'post1', false);
// An unrelated preference must NOT re-evaluate draft-sync capability.
expect(DraftSyncManager.handleCapabilityChange).not.toHaveBeenCalled();
});
it('re-evaluates draft-sync capability when the sync_drafts preference changes (Phase 5)', async () => {
const msg = {
data: {
preference: JSON.stringify(syncDraftsPreference),
},
} as WebSocketMessage;
jest.mocked(differsFromLocalNameFormat).mockResolvedValue(false);
jest.mocked(getHasCRTChanged).mockResolvedValue(false);
await handlePreferenceChangedEvent(serverUrl, msg);
expect(DraftSyncManager.handleCapabilityChange).toHaveBeenCalledWith(serverUrl);
});
it('should handle name format changes', async () => {
const msg = {
data: {
preference: JSON.stringify(mockPreference),
},
} as WebSocketMessage;
jest.mocked(differsFromLocalNameFormat).mockResolvedValue(true);
jest.mocked(getHasCRTChanged).mockResolvedValue(false);
await handlePreferenceChangedEvent(serverUrl, msg);
expect(updateDmGmDisplayName).toHaveBeenCalledWith(serverUrl);
});
it('should handle CRT changes', async () => {
const msg = {
data: {
preference: JSON.stringify(mockPreference),
},
} as WebSocketMessage;
jest.mocked(differsFromLocalNameFormat).mockResolvedValue(false);
jest.mocked(getHasCRTChanged).mockResolvedValue(true);
await handlePreferenceChangedEvent(serverUrl, msg);
expect(handleCRTToggled).toHaveBeenCalledWith(serverUrl);
});
it('should skip a stale saved-post re-save coming from a local unsave', async () => {
// The single preference is a SAVED_POST/value='true' that the user just
// unsaved locally; the echoed websocket event must be filtered out so we
// don't re-add the post that was removed.
jest.mocked(EphemeralStore.isRecentlyUnsavedSavedPost).mockReturnValue(true);
const msg = {
data: {
preference: JSON.stringify(mockPreference),
},
} as WebSocketMessage;
await handlePreferenceChangedEvent(serverUrl, msg);
expect(operator.handlePreferences).not.toHaveBeenCalled();
});
});
describe('handlePreferencesChangedEvent', () => {
const mockPreferences = [{
category: Preferences.CATEGORIES.SAVED_POST,
name: 'post1',
user_id: 'user1',
value: 'true',
}];
it('should handle enabling CRT', async () => {
jest.mocked(EphemeralStore.isEnablingCRT).mockReturnValue(true);
const msg = {
data: {
preferences: JSON.stringify(mockPreferences),
},
} as WebSocketMessage;
await handlePreferencesChangedEvent(serverUrl, msg);
expect(operator.handlePreferences).not.toHaveBeenCalled();
});
it('should handle multiple preferences change', async () => {
const msg = {
data: {
preferences: JSON.stringify(mockPreferences),
},
} as WebSocketMessage;
jest.mocked(differsFromLocalNameFormat).mockResolvedValue(false);
jest.mocked(getHasCRTChanged).mockResolvedValue(false);
jest.mocked(getPostById).mockResolvedValue(undefined);
await handlePreferencesChangedEvent(serverUrl, msg);
expect(operator.handlePreferences).toHaveBeenCalledWith({
prepareRecordsOnly: false,
preferences: mockPreferences,
});
expect(fetchPostById).toHaveBeenCalledWith(serverUrl, 'post1', false);
});
it('should handle name format changes in bulk', async () => {
const msg = {
data: {
preferences: JSON.stringify(mockPreferences),
},
} as WebSocketMessage;
jest.mocked(differsFromLocalNameFormat).mockResolvedValue(true);
jest.mocked(getHasCRTChanged).mockResolvedValue(false);
await handlePreferencesChangedEvent(serverUrl, msg);
expect(updateDmGmDisplayName).toHaveBeenCalledWith(serverUrl);
});
it('should skip when the entire batch is stale saved-post re-saves', async () => {
jest.mocked(EphemeralStore.isRecentlyUnsavedSavedPost).mockReturnValue(true);
const msg = {
data: {
preferences: JSON.stringify(mockPreferences),
},
} as WebSocketMessage;
await handlePreferencesChangedEvent(serverUrl, msg);
expect(operator.handlePreferences).not.toHaveBeenCalled();
});
it('should keep non-stale preferences and only drop the stale saved post', async () => {
const stalePost = {
category: Preferences.CATEGORIES.SAVED_POST,
name: 'stale-post',
user_id: 'user1',
value: 'true',
};
const otherPreference = {
category: Preferences.CATEGORIES.DISPLAY_SETTINGS,
name: 'name_format',
user_id: 'user1',
value: 'full_name',
};
// Only the saved-post entry is in the recently-unsaved set.
jest.mocked(EphemeralStore.isRecentlyUnsavedSavedPost).mockImplementation((_, name) => name === 'stale-post');
jest.mocked(differsFromLocalNameFormat).mockResolvedValue(false);
jest.mocked(getHasCRTChanged).mockResolvedValue(false);
jest.mocked(getPostById).mockResolvedValue(undefined);
const msg = {
data: {
preferences: JSON.stringify([stalePost, otherPreference]),
},
} as WebSocketMessage;
await handlePreferencesChangedEvent(serverUrl, msg);
expect(operator.handlePreferences).toHaveBeenCalledWith({
prepareRecordsOnly: false,
preferences: [otherPreference],
});
});
});
describe('handlePreferencesDeletedEvent', () => {
const mockPreferences = [{
category: Preferences.CATEGORIES.SAVED_POST,
name: 'post1',
user_id: 'user1',
value: 'true',
}];
it('should delete preferences', async () => {
const msg = {
data: {
preferences: JSON.stringify(mockPreferences),
},
} as WebSocketMessage;
await handlePreferencesDeletedEvent(serverUrl, msg);
expect(deletePreferences).toHaveBeenCalled();
});
it('should handle invalid preferences data', async () => {
const msg = {
data: {
preferences: 'invalid-json',
},
} as WebSocketMessage;
await handlePreferencesDeletedEvent(serverUrl, msg);
expect(deletePreferences).not.toHaveBeenCalled();
});
});
});