mattermost-mobile-upstream/app/actions/websocket/properties.test.ts
Andre Vasconcelos e18fc6921e
MM-68208 Implementing global and channel-level banners on mobile (#9752)
* Expo-Router partial migration

* Full migration to ExpoRouter

* i18n

* add tests

* library hardware-keyboard android new arch support fix

* library rnshare android new arch support fix

* library rnutils android new arch support fix

* library secure-pdf-viewer add new arch support

* Enable new arch on iOS and Android

* update emm and network client with new-arch

* update intune to use new-arch

* performance improvements

* fix tests

* fixes post input on new-arch

* Merge branch 'main' into expo-router

* fix android emoji picker

* align package-lock.json

* i18n

* feedback review

* feedback review

* android 16kb patch

* Refactored emoji picker keyboard using a state machine

* set android launch_screen in drawables instead of layout

* no conditional hooks

* remove duplicate call in test

* address feedback

* fix tests and address more feedback

* small corrections

* small corrections

* small corrections

* fix draft test

* fix draft test 2

* remove navigateToScreen in draff test

* fix nit in draft test

* remove doc file

* remove doc

* run tests in parallel

* Feedback review

* fix snapshots

* improve test coverage

* fix i18n

* upgrade to React Native 0.83.9, Expo 55, React 19, and New Architecture

Bumps core dependencies to their latest versions:
- React Native 0.77.3 → 0.83.9 (New Architecture enabled)
- React 18.3.1 → 19.2.5
- Expo SDK 52 → 55
- TypeScript 5.8.3 → 6.0.3
- Node.js 22.16.0 → 24.15.0
- react-native-reanimated 3.17.3 → 4.3.0
- Various other dependency upgrades

Migrates iOS AppDelegate from Objective-C to Swift, updates Android
build tooling and Gradle wrapper, refreshes all patches and font
assets, and adapts app code, tests, and CI workflows throughout for
API changes introduced by these upgrades.

* remove unecessary dismissKeyboard in notifications

* feedback review

* update intune to use new-arch

* update @mattermost deps

* missing i18n string

* additional fixes

* update fastlane

* Re-implementing global classification banners on top of rn83

* Refactoring to de-couple the classification banner from the layout

* Implementing per-channel banners on mobile

* Removing custom header in favor of common component

* Making fixes for coderabbit

* Improving padding calculation

* Converting global classification banner to use portals

* Removing dead code, adding deletion check

* Addressing dryrun securit concerns

* Removing call for template field, improving consistency

* MM-68208 Storing system property values in WatermelonDB (#9781)

* Added persistence layer to system properties

* Making debounce behavior more consistent

* Cleaning up debounce logic from store persistence

* Addressing PR feedback

* Removing ephemeral store usage and employing observables

- Changing name of group to access_control

* Updating unit tests

* Refactoring to improve code consistency

- Removing any patterns introduced that weren't already established in the repo
- Removing hooks with database reads in favor of withObservables and withDatabase pattern
- Simplifying _layout.tsx by removing inset modification, now handled in the Container HoC component
- Moved some repeated hook logic into its own utils file

* Refactoring to use propertyfield and propertyvalue tables instead of system

- Simplified remote actions to purely perform API call, and call a local action to sync values
- Using local action layer to perform syncing and removal operations of property fields and values
- Observables now pre-filter for active fields / values via querying for delete_at=0

* Improving consistency of local actions

- Added unit tests for syncPropertyFieldsByGroupId, syncPropertyValuesByTargetId, clearClassificationData

* Replacing local actions with operator handlers

* Removing needless mocks from unit tests

* Consolidating operator handlers

- Leaving 1 handler for fields and 1 for values, each of them evaluating whether to delete or upsert values received in the function call

* MM-68208 Making changes based on feedback

- Removing !visible guard in global classification container
- Increasing clarity of comment for clearing of stale fields
- Updating log messages to be more clear

* Batching database operations together for fields and values

* Consolidating API call for fetching classification data

- Preparation for caching mechanism

* Updating field names to the unified classification

* Updating E2E test values to match current field names

---------

Co-authored-by: Elias Nahum <nahumhbl@gmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
2026-07-08 12:47:01 +03:00

296 lines
10 KiB
TypeScript

// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
// See LICENSE.txt for license information.
import {Q, type Database} from '@nozbe/watermelondb';
import {MM_TABLES} from '@constants/database';
import DatabaseManager from '@database/manager';
import {handlePropertyFieldCreatedOrUpdated, handlePropertyFieldDeleted, handlePropertyValuesUpdated} from './properties';
import type {PropertyFieldModel, PropertyValueModel} from '@database/models/server';
const {PROPERTY_FIELD, PROPERTY_VALUE} = MM_TABLES.SERVER;
const serverUrl = 'ws-properties.test.com';
const groupId = 'test_group';
const makeField = (id: string, overrides?: Partial<PropertyField>): PropertyField => ({
id,
group_id: groupId,
name: `field_${id}`,
type: 'select',
object_type: 'template',
target_type: 'system',
target_id: '',
delete_at: 0,
create_at: 1000,
update_at: 1000,
attrs: {},
...overrides,
});
const makeValue = (fieldId: string, value: string, overrides?: Partial<PropertyValue<string>>): PropertyValue<string> => ({
id: `val-${fieldId}`,
target_id: 'system',
target_type: 'system',
group_id: groupId,
field_id: fieldId,
value,
create_at: 1000,
update_at: 1000,
delete_at: 0,
...overrides,
});
const getStoredFields = async (database: Database) => {
const records = await database.get<PropertyFieldModel>(PROPERTY_FIELD).query(Q.where('group_id', groupId)).fetch();
return records;
};
const getStoredValues = async (database: Database, targetId: string) => {
const records = await database.get<PropertyValueModel>(PROPERTY_VALUE).query(Q.where('target_id', targetId)).fetch();
return records;
};
beforeEach(async () => {
await DatabaseManager.init([serverUrl]);
});
afterEach(async () => {
await DatabaseManager.destroyServerDatabase(serverUrl);
});
describe('handlePropertyFieldCreatedOrUpdated', () => {
it('should add a field to the DB', async () => {
const field = makeField('f1');
const msg = {
event: 'property_field_created',
data: {property_field: JSON.stringify(field), object_type: 'template'},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyFieldCreatedOrUpdated(serverUrl, msg);
const {database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
const fields = await getStoredFields(database);
expect(fields).toHaveLength(1);
expect(fields[0].id).toBe('f1');
});
it('should update an existing field in the DB', async () => {
const {operator, database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
await operator.handlePropertyFields({fields: [makeField('f1')], prepareRecordsOnly: false});
const updated = makeField('f1', {name: 'updated'});
const msg = {
event: 'property_field_updated',
data: {property_field: JSON.stringify(updated), object_type: 'template'},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyFieldCreatedOrUpdated(serverUrl, msg);
const fields = await getStoredFields(database);
expect(fields).toHaveLength(1);
expect(fields[0].name).toBe('updated');
});
it('should ignore events with no property_field data', async () => {
const msg = {
event: 'property_field_created',
data: {},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyFieldCreatedOrUpdated(serverUrl, msg);
const {database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
expect(await getStoredFields(database)).toHaveLength(0);
});
it('should ignore events with invalid JSON', async () => {
const msg = {
event: 'property_field_created',
data: {property_field: 'not-json'},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyFieldCreatedOrUpdated(serverUrl, msg);
const {database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
expect(await getStoredFields(database)).toHaveLength(0);
});
});
describe('handlePropertyFieldDeleted', () => {
it('should remove a field and its values from the DB by id', async () => {
const {operator, database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
await operator.handlePropertyFields({fields: [makeField('f1'), makeField('f2')], prepareRecordsOnly: false});
await operator.handlePropertyValues({values: [makeValue('f1', 'v1')], prepareRecordsOnly: false});
const msg = {
event: 'property_field_deleted',
data: {field_id: 'f1', object_type: 'template'},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyFieldDeleted(serverUrl, msg);
const fields = await getStoredFields(database);
expect(fields).toHaveLength(1);
expect(fields[0].id).toBe('f2');
expect(await getStoredValues(database, 'system')).toHaveLength(0);
});
it('should do nothing when field_id is missing', async () => {
const {operator, database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
await operator.handlePropertyFields({fields: [makeField('f1')], prepareRecordsOnly: false});
const msg = {
event: 'property_field_deleted',
data: {object_type: 'template'},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyFieldDeleted(serverUrl, msg);
expect(await getStoredFields(database)).toHaveLength(1);
});
it('should do nothing when field_id does not match any stored field', async () => {
const {operator, database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
await operator.handlePropertyFields({fields: [makeField('f1')], prepareRecordsOnly: false});
const msg = {
event: 'property_field_deleted',
data: {field_id: 'non-existent', object_type: 'template'},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyFieldDeleted(serverUrl, msg);
expect(await getStoredFields(database)).toHaveLength(1);
});
});
describe('handlePropertyValuesUpdated', () => {
it('should add new values to the DB', async () => {
const values = [makeValue('f1', 'v1'), makeValue('f2', 'v2')];
const msg = {
event: 'property_values_updated',
data: {values: JSON.stringify(values)},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyValuesUpdated(serverUrl, msg);
const {database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
expect(await getStoredValues(database, 'system')).toHaveLength(2);
});
it('should update existing values in the DB', async () => {
const {operator, database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
await operator.handlePropertyValues({values: [makeValue('f1', 'old')], prepareRecordsOnly: false});
const updated = [makeValue('f1', 'new')];
const msg = {
event: 'property_values_updated',
data: {values: JSON.stringify(updated)},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyValuesUpdated(serverUrl, msg);
const stored = await getStoredValues(database, 'system');
expect(stored).toHaveLength(1);
expect(stored[0].value).toBe('new');
});
it('should ignore events with no values', async () => {
const msg = {
event: 'property_values_updated',
data: {},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyValuesUpdated(serverUrl, msg);
const {database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
expect(await getStoredValues(database, 'system')).toHaveLength(0);
});
it('should ignore events with invalid JSON', async () => {
const msg = {
event: 'property_values_updated',
data: {values: 'not-json'},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyValuesUpdated(serverUrl, msg);
const {database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
expect(await getStoredValues(database, 'system')).toHaveLength(0);
});
it('should ignore events with empty values array', async () => {
const msg = {
event: 'property_values_updated',
data: {values: '[]'},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyValuesUpdated(serverUrl, msg);
const {database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
expect(await getStoredValues(database, 'system')).toHaveLength(0);
});
it('should store channel property values by their target_id', async () => {
const channelId = 'channel-abc';
const channelValue = makeValue('chan-field', 'level-1', {id: 'val-chan', target_id: channelId, target_type: 'channel'});
const msg = {
event: 'property_values_updated',
data: {values: JSON.stringify([channelValue])},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyValuesUpdated(serverUrl, msg);
const {database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
const stored = await getStoredValues(database, channelId);
expect(stored).toHaveLength(1);
expect(stored[0].value).toBe('level-1');
});
it('should isolate values across different target ids', async () => {
const channelId = 'channel-xyz';
const systemVal = makeValue('sys-field', 'sys-val');
const channelVal = makeValue('chan-field', 'chan-val', {id: 'val-chan', target_id: channelId, target_type: 'channel'});
const msg = {
event: 'property_values_updated',
data: {values: JSON.stringify([systemVal, channelVal])},
broadcast: {},
seq: 1,
} as WebSocketMessage;
await handlePropertyValuesUpdated(serverUrl, msg);
const {database} = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
expect(await getStoredValues(database, 'system')).toHaveLength(1);
expect(await getStoredValues(database, channelId)).toHaveLength(1);
});
});