mirror of
https://github.com/mattermost/mattermost-mobile.git
synced 2026-11-11 05:30:12 +00:00
* Expo-Router partial migration * Full migration to ExpoRouter * i18n * add tests * library hardware-keyboard android new arch support fix * library rnshare android new arch support fix * library rnutils android new arch support fix * library secure-pdf-viewer add new arch support * Enable new arch on iOS and Android * update emm and network client with new-arch * update intune to use new-arch * performance improvements * fix tests * fixes post input on new-arch * Merge branch 'main' into expo-router * fix android emoji picker * align package-lock.json * i18n * feedback review * feedback review * android 16kb patch * Refactored emoji picker keyboard using a state machine * set android launch_screen in drawables instead of layout * no conditional hooks * remove duplicate call in test * address feedback * fix tests and address more feedback * small corrections * small corrections * small corrections * fix draft test * fix draft test 2 * remove navigateToScreen in draff test * fix nit in draft test * remove doc file * remove doc * run tests in parallel * Feedback review * fix snapshots * improve test coverage * fix i18n * upgrade to React Native 0.83.9, Expo 55, React 19, and New Architecture Bumps core dependencies to their latest versions: - React Native 0.77.3 → 0.83.9 (New Architecture enabled) - React 18.3.1 → 19.2.5 - Expo SDK 52 → 55 - TypeScript 5.8.3 → 6.0.3 - Node.js 22.16.0 → 24.15.0 - react-native-reanimated 3.17.3 → 4.3.0 - Various other dependency upgrades Migrates iOS AppDelegate from Objective-C to Swift, updates Android build tooling and Gradle wrapper, refreshes all patches and font assets, and adapts app code, tests, and CI workflows throughout for API changes introduced by these upgrades. * remove unecessary dismissKeyboard in notifications * feedback review * update intune to use new-arch * update @mattermost deps * missing i18n string * additional fixes * update fastlane * Re-implementing global classification banners on top of rn83 * Refactoring to de-couple the classification banner from the layout * Implementing per-channel banners on mobile * Removing custom header in favor of common component * Making fixes for coderabbit * Improving padding calculation * Converting global classification banner to use portals * Removing dead code, adding deletion check * Addressing dryrun securit concerns * Removing call for template field, improving consistency * MM-68208 Storing system property values in WatermelonDB (#9781) * Added persistence layer to system properties * Making debounce behavior more consistent * Cleaning up debounce logic from store persistence * Addressing PR feedback * Removing ephemeral store usage and employing observables - Changing name of group to access_control * Updating unit tests * Refactoring to improve code consistency - Removing any patterns introduced that weren't already established in the repo - Removing hooks with database reads in favor of withObservables and withDatabase pattern - Simplifying _layout.tsx by removing inset modification, now handled in the Container HoC component - Moved some repeated hook logic into its own utils file * Refactoring to use propertyfield and propertyvalue tables instead of system - Simplified remote actions to purely perform API call, and call a local action to sync values - Using local action layer to perform syncing and removal operations of property fields and values - Observables now pre-filter for active fields / values via querying for delete_at=0 * Improving consistency of local actions - Added unit tests for syncPropertyFieldsByGroupId, syncPropertyValuesByTargetId, clearClassificationData * Replacing local actions with operator handlers * Removing needless mocks from unit tests * Consolidating operator handlers - Leaving 1 handler for fields and 1 for values, each of them evaluating whether to delete or upsert values received in the function call * MM-68208 Making changes based on feedback - Removing !visible guard in global classification container - Increasing clarity of comment for clearing of stale fields - Updating log messages to be more clear * Batching database operations together for fields and values * Consolidating API call for fetching classification data - Preparation for caching mechanism * Updating field names to the unified classification * Updating E2E test values to match current field names --------- Co-authored-by: Elias Nahum <nahumhbl@gmail.com> Co-authored-by: Mattermost Build <build@mattermost.com>
116 lines
4.2 KiB
TypeScript
116 lines
4.2 KiB
TypeScript
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
import {firstValueFrom} from 'rxjs';
|
|
|
|
import {CLASSIFICATIONS_SYSTEM_VALUE_TARGET_ID} from '@constants/classification';
|
|
import DatabaseManager from '@database/manager';
|
|
|
|
import {
|
|
observeChannelClassificationBanner,
|
|
observeClassificationBannerState,
|
|
} from './properties';
|
|
|
|
import type ServerDataOperator from '@database/operator/server_data_operator';
|
|
import type {Database} from '@nozbe/watermelondb';
|
|
|
|
const serverUrl = 'properties.query.test.com';
|
|
const groupId = 'access_control';
|
|
let database: Database;
|
|
let operator: ServerDataOperator;
|
|
|
|
const makeField = (overrides?: Partial<PropertyField>): PropertyField => ({
|
|
id: 'sys-1',
|
|
group_id: groupId,
|
|
name: 'classification',
|
|
type: 'select',
|
|
object_type: 'system',
|
|
target_type: 'system',
|
|
target_id: '',
|
|
delete_at: 0,
|
|
create_at: 1000,
|
|
update_at: 1000,
|
|
attrs: {
|
|
actions: ['display_banner_top'],
|
|
options: [
|
|
{id: 'opt-ts', name: 'TOP SECRET', color: '#FCE83A'},
|
|
{id: 'opt-s', name: 'SECRET', color: '#FF0000'},
|
|
],
|
|
},
|
|
...overrides,
|
|
});
|
|
|
|
const makeValue = (overrides?: Partial<PropertyValue<string>>): PropertyValue<string> => ({
|
|
id: 'val-1',
|
|
target_id: CLASSIFICATIONS_SYSTEM_VALUE_TARGET_ID,
|
|
target_type: 'system',
|
|
group_id: groupId,
|
|
field_id: 'sys-1',
|
|
value: 'opt-ts',
|
|
create_at: 1000,
|
|
update_at: 1000,
|
|
delete_at: 0,
|
|
...overrides,
|
|
});
|
|
|
|
const seedFields = (fields: PropertyField[]) => operator.handlePropertyFields({fields, prepareRecordsOnly: false});
|
|
const seedValues = (values: Array<PropertyValue<string>>) => operator.handlePropertyValues({values, prepareRecordsOnly: false});
|
|
|
|
beforeEach(async () => {
|
|
await DatabaseManager.init([serverUrl]);
|
|
const db = DatabaseManager.getServerDatabaseAndOperator(serverUrl);
|
|
database = db.database;
|
|
operator = db.operator;
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await DatabaseManager.destroyServerDatabase(serverUrl);
|
|
});
|
|
|
|
describe('observeClassificationBannerState', () => {
|
|
it('should emit a visible banner state when field and value are present', async () => {
|
|
await seedFields([makeField()]);
|
|
await seedValues([makeValue()]);
|
|
|
|
const state = await firstValueFrom(observeClassificationBannerState(database));
|
|
expect(state).toEqual({visible: true, levelName: 'TOP SECRET', color: '#FCE83A'});
|
|
});
|
|
|
|
it('should emit a hidden banner state when the field is soft-deleted', async () => {
|
|
await seedFields([makeField({delete_at: 5000})]);
|
|
await seedValues([makeValue()]);
|
|
|
|
const state = await firstValueFrom(observeClassificationBannerState(database));
|
|
expect(state).toEqual({visible: false, levelName: '', color: ''});
|
|
});
|
|
|
|
it('should emit a hidden banner state when no data exists', async () => {
|
|
const state = await firstValueFrom(observeClassificationBannerState(database));
|
|
expect(state).toEqual({visible: false, levelName: '', color: ''});
|
|
});
|
|
});
|
|
|
|
describe('observeChannelClassificationBanner', () => {
|
|
const channelId = 'channel-123';
|
|
|
|
it('should emit a channel banner from the channel value and field options', async () => {
|
|
await seedFields([makeField({id: 'cf-1', name: 'classification', object_type: 'channel', attrs: {options: [{id: 'level-secret', name: 'Secret', color: '#FF0000'}]}})]);
|
|
await seedValues([makeValue({id: 'cv-1', target_id: channelId, target_type: 'channel', field_id: 'cf-1', value: 'level-secret'})]);
|
|
|
|
const state = await firstValueFrom(observeChannelClassificationBanner(database, channelId));
|
|
expect(state.hasClassification).toBe(true);
|
|
expect(state.classificationBanner).toEqual({
|
|
enabled: true,
|
|
text: '**Secret**',
|
|
background_color: '#FF0000',
|
|
});
|
|
});
|
|
|
|
it('should emit no classification when there is no channel value', async () => {
|
|
await seedFields([makeField({id: 'cf-1', name: 'classification', object_type: 'channel'})]);
|
|
|
|
const state = await firstValueFrom(observeChannelClassificationBanner(database, channelId));
|
|
expect(state.hasClassification).toBe(false);
|
|
});
|
|
});
|