mirror of
https://github.com/mattermost/mattermost-mobile.git
synced 2026-11-14 07:00:20 +00:00
* [MM-16593] [MM-17175] [MM-17164] [MM-17189] [MM-17181] Android - Upgrade to RN 0.60 (#3145) * Upgrade to react-native 0.60 * Use @sentry/react-native * Manually link @sentry/react-native * Address review comments * Jetify after install * Call jetify from node_modules * [MM-17785] iOS - Upgrade to RN 0.60 (#3153) * Upgrade to react-native 0.60 * Use @sentry/react-native * Manually link @sentry/react-native * Address review comments * Jetify after install * Call jetify from node_modules * Get app building for iOS * Revert react-native-image-picker upgrade * Minor version upgrade of react-native-image-picker * [MM-17142] Convert all string refs to callbacks (#3217) * Replace string refs * Fix tests * Don't use inline functions * Fix mattermost-redux reversion from master merge * [MM-18336] Upload Sentry debug symbols only when SENTRY_ENABLED is true (#3227) * Upgrade @sentry/react-native * Run Sentry gradle tasks only when enabled * Upgrade @sentry/react-native and remove extra Sentry build phase * [MM-17144] Use Hermes (#3226) * Replace string refs * Fix tests * Don't use inline functions * Fix mattermost-redux reversion from master merge * Use Hermes * bundleCommand ram-bundle no longer needed * Require harmony-reflect only for Android * Fix failing test * Path react-native's splitLayoutProps (#3337) * [MM-18867] [MM-17186] [MM-18866] [MM-19447] [MM-18967] Upgrade to RN 0.61.2 (#3423) * Upgrade to RN 0.61.2 * Update rn-fetch-blob commit hash * Update react-native-keyboard-tracking-view commit hash * Use react-native-youtube with AVPlayer fix * Fix jest mocks * Use updated document picker API * Remove unnecessary linking * Revert "MM-17759 Add code highlighting (#3072)" This reverts commit26b999e885. * Fix share extension * Revert "Revert "MM-17759 Add code highlighting (#3072)"" This reverts commit52aca776b1. * Address PR reviews * Rename patch to match version * Update react-native-youtube patch * Update dependencies * Fix RNDocViewer reference * Update tests and revert to redux-persist 4.10.2 * Revert "Revert "Revert "MM-17759 Add code highlighting (#3072)""" This reverts commit5ef383be26. * Android fixes after dep upgrades * Use fresco 2.0.0 * Use mattermost forks * Use React-Core in Mattermost.scheme instead of react * Remove packager (#3452) * Remove Pods from source control * Fix unit tests * Add new line before entering the keystore in gradle.properties * set ios as working directory for cocoapods * Cache cocoapods on circleCI builds * set ios as working dir * fix cocoapods cache key * Unify fastlane and npm dependencies command * Use package-lock.json checksum for npm cache * Fix package.json and use the checksum as the cache key * Fix package.json and use the checksum as the cache key * changes to circleci.yaml fastlane and removing pods from git * Fix Mattermost.xcodeproj * Update coocoapods to 1.7.5 and fix xcode header search paths * Update package-lock.json * Remove unused tooltip component * Fix incorrect ref * Disable Hermes (#3460) * Revert "Remove packager (#3452)" This reverts commitb2a79e184b. * Disable Hermes :'( * Update preloaded modules * Fix packages moduleNames and modulePaths, update snapshots and update mm-redux (ts version) * remove document picker from modulePaths * Fix package-lock.json * Add eslint disable rules
122 lines
6.5 KiB
Diff
122 lines
6.5 KiB
Diff
diff --git a/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/react/NavigationModule.java b/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/react/NavigationModule.java
|
|
index 82b434b..858ca59 100644
|
|
--- a/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/react/NavigationModule.java
|
|
+++ b/node_modules/react-native-navigation/lib/android/app/src/main/java/com/reactnativenavigation/react/NavigationModule.java
|
|
@@ -26,6 +26,7 @@ import com.reactnativenavigation.viewcontrollers.ViewController;
|
|
import com.reactnativenavigation.viewcontrollers.navigator.Navigator;
|
|
|
|
import java.util.ArrayList;
|
|
+import java.lang.ClassCastException;
|
|
|
|
import androidx.annotation.NonNull;
|
|
import androidx.annotation.Nullable;
|
|
@@ -54,14 +55,18 @@ public class NavigationModule extends ReactContextBaseJavaModule {
|
|
reactContext.addLifecycleEventListener(new LifecycleEventListenerAdapter() {
|
|
@Override
|
|
public void onHostResume() {
|
|
- eventEmitter = new EventEmitter(reactContext);
|
|
- navigator().setEventEmitter(eventEmitter);
|
|
- layoutFactory.init(
|
|
- activity(),
|
|
- eventEmitter,
|
|
- navigator().getChildRegistry(),
|
|
- ((NavigationApplication) activity().getApplication()).getExternalComponents()
|
|
- );
|
|
+ try {
|
|
+ eventEmitter = new EventEmitter(reactContext);
|
|
+ navigator().setEventEmitter(eventEmitter);
|
|
+ layoutFactory.init(
|
|
+ activity(),
|
|
+ eventEmitter,
|
|
+ navigator().getChildRegistry(),
|
|
+ ((NavigationApplication) activity().getApplication()).getExternalComponents()
|
|
+ );
|
|
+ } catch (ClassCastException e) {
|
|
+ // The most current activity is not a NavigationActivity
|
|
+ }
|
|
}
|
|
});
|
|
}
|
|
diff --git a/node_modules/react-native-navigation/lib/ios/RNNCommandsHandler.m b/node_modules/react-native-navigation/lib/ios/RNNCommandsHandler.m
|
|
index 2d34f5a..82e7bcc 100644
|
|
--- a/node_modules/react-native-navigation/lib/ios/RNNCommandsHandler.m
|
|
+++ b/node_modules/react-native-navigation/lib/ios/RNNCommandsHandler.m
|
|
@@ -69,7 +69,7 @@ - (void)setRoot:(NSDictionary*)layout commandId:(NSString*)commandId completion:
|
|
}
|
|
}
|
|
|
|
- [_modalManager dismissAllModalsAnimated:NO];
|
|
+ [_modalManager dismissAllModalsAnimated:NO completion:nil];
|
|
|
|
UIViewController *vc = [_controllerFactory createLayout:layout[@"root"]];
|
|
|
|
@@ -289,10 +289,9 @@ - (void)dismissAllModals:(NSDictionary *)mergeOptions commandId:(NSString*)comma
|
|
[CATransaction begin];
|
|
[CATransaction setCompletionBlock:^{
|
|
[_eventEmitter sendOnNavigationCommandCompletion:dismissAllModals commandId:commandId params:@{}];
|
|
- completion();
|
|
}];
|
|
RNNNavigationOptions* options = [[RNNNavigationOptions alloc] initWithDict:mergeOptions];
|
|
- [_modalManager dismissAllModalsAnimated:[options.animations.dismissModal.enable getWithDefaultValue:YES]];
|
|
+ [_modalManager dismissAllModalsAnimated:[options.animations.dismissModal.enable getWithDefaultValue:YES] completion:completion];
|
|
|
|
[CATransaction commit];
|
|
}
|
|
diff --git a/node_modules/react-native-navigation/lib/ios/RNNModalManager.h b/node_modules/react-native-navigation/lib/ios/RNNModalManager.h
|
|
index 9809db0..a602c92 100644
|
|
--- a/node_modules/react-native-navigation/lib/ios/RNNModalManager.h
|
|
+++ b/node_modules/react-native-navigation/lib/ios/RNNModalManager.h
|
|
@@ -19,6 +19,6 @@ typedef void (^RNNTransitionRejectionBlock)(NSString *code, NSString *message, N
|
|
- (void)showModal:(UIViewController *)viewController animated:(BOOL)animated completion:(RNNTransitionWithComponentIdCompletionBlock)completion;
|
|
- (void)showModal:(UIViewController *)viewController animated:(BOOL)animated hasCustomAnimation:(BOOL)hasCustomAnimation completion:(RNNTransitionWithComponentIdCompletionBlock)completion;
|
|
- (void)dismissModal:(UIViewController *)viewController completion:(RNNTransitionCompletionBlock)completion;
|
|
-- (void)dismissAllModalsAnimated:(BOOL)animated;
|
|
+- (void)dismissAllModalsAnimated:(BOOL)animated completion:(RNNTransitionCompletionBlock)completion;
|
|
|
|
@end
|
|
diff --git a/node_modules/react-native-navigation/lib/ios/RNNModalManager.m b/node_modules/react-native-navigation/lib/ios/RNNModalManager.m
|
|
index 91adb14..8aa3935 100644
|
|
--- a/node_modules/react-native-navigation/lib/ios/RNNModalManager.m
|
|
+++ b/node_modules/react-native-navigation/lib/ios/RNNModalManager.m
|
|
@@ -50,9 +50,16 @@ - (void)dismissModal:(UIViewController *)viewController completion:(RNNTransitio
|
|
}
|
|
}
|
|
|
|
--(void)dismissAllModalsAnimated:(BOOL)animated {
|
|
+-(void)dismissAllModalsAnimated:(BOOL)animated completion:(RNNTransitionCompletionBlock)completion {
|
|
+ if (!_presentedModals || !_presentedModals.count) {
|
|
+ if (completion) {
|
|
+ completion();
|
|
+ }
|
|
+ return;
|
|
+ }
|
|
+
|
|
UIViewController *root = UIApplication.sharedApplication.delegate.window.rootViewController;
|
|
- [root dismissViewControllerAnimated:animated completion:nil];
|
|
+ [root dismissViewControllerAnimated:animated completion:completion];
|
|
[_delegate dismissedMultipleModals:_presentedModals];
|
|
[_pendingModalIdsToDismiss removeAllObjects];
|
|
[_presentedModals removeAllObjects];
|
|
diff --git a/node_modules/react-native-navigation/lib/ios/ReactNativeNavigationTests/RNNModalManagerTest.m b/node_modules/react-native-navigation/lib/ios/ReactNativeNavigationTests/RNNModalManagerTest.m
|
|
index 1f9df16..23b6528 100644
|
|
--- a/node_modules/react-native-navigation/lib/ios/ReactNativeNavigationTests/RNNModalManagerTest.m
|
|
+++ b/node_modules/react-native-navigation/lib/ios/ReactNativeNavigationTests/RNNModalManagerTest.m
|
|
@@ -51,7 +51,7 @@ - (void)testDismissMultipleModalsInvokeDelegateWithCorrectParameters {
|
|
[_modalManager showModal:_vc3 animated:NO completion:nil];
|
|
|
|
_modalManager.delegate = self;
|
|
- [_modalManager dismissAllModalsAnimated:NO];
|
|
+ [_modalManager dismissAllModalsAnimated:NO completion:nil];
|
|
|
|
XCTAssertTrue(_modalDismissedCount == 3);
|
|
}
|
|
@@ -87,7 +87,7 @@ - (void)testDismissAllModals_AfterDismissingPreviousModal_InvokeDelegateWithCorr
|
|
[_modalManager dismissModal:_vc2 completion:nil];
|
|
|
|
XCTAssertTrue(_modalDismissedCount == 1);
|
|
- [_modalManager dismissAllModalsAnimated:NO];
|
|
+ [_modalManager dismissAllModalsAnimated:NO completion:nil];
|
|
XCTAssertTrue(_modalDismissedCount == 2);
|
|
}
|
|
|